console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-38860: Collapse/Expand Feature Added, Removal Option Removed in Version 4.16

Open lokanandaprabhu opened this issue 1 year ago • 7 comments

Fixes: https://issues.redhat.com/browse/OCPBUGS-38860

Analysis / Root cause: From OCP 4.16, getting started section was changed to use expandable section of PatternFly and the removal option was removed.

Solution Description: Added removal option for getting started section in Add page of developer perspective and in Cluster overview page.

Screen shots / Gifs for design review:

https://github.com/user-attachments/assets/0f032e47-ea4c-4183-ac3b-4ef686c76518

Unit test coverage report: NA

Test setup:

1. Go to Web console. Click on the "Getting started resources." 
2. Then you can expand and collapse this tab.
3. But there is no option to directly remove this tab.  

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge

lokanandaprabhu avatar Sep 10 '24 04:09 lokanandaprabhu

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-38860, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-38860

Analysis / Root cause: From OCP 4.16, getting started section was changed to use expandable section of PatternFly and the removal option was removed.

Solution Description: Added removal option for getting started section in Add page of developer perspective and in Cluster overview page.

Screen shots / Gifs for design review:

https://github.com/user-attachments/assets/0f032e47-ea4c-4183-ac3b-4ef686c76518

Unit test coverage report: NA

Test setup:

  1. Go to Web console. Click on the "Getting started resources."
  2. Then you can expand and collapse this tab.
  3. But there is no option to directly remove this tab.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 10 '24 04:09 openshift-ci-robot

/jira refresh

lokanandaprabhu avatar Sep 10 '24 05:09 lokanandaprabhu

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-38860, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 10 '24 05:09 openshift-ci-robot

/cc @vikram-raj

lokanandaprabhu avatar Sep 10 '24 05:09 lokanandaprabhu

tested locally, works fine. just one nit

logonoff avatar Oct 17 '24 15:10 logonoff

Resolved review comment.


---In light mode--- Screenshot 2024-11-05 at 12 21 05 PM


---In dark mode---

Screenshot 2024-11-05 at 12 21 30 PM

lokanandaprabhu avatar Nov 05 '24 06:11 lokanandaprabhu

/retest

lokanandaprabhu avatar Nov 05 '24 14:11 lokanandaprabhu

/retest

lokanandaprabhu avatar Nov 06 '24 06:11 lokanandaprabhu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 12 '24 11:11 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 701dcf11eea9782e0ef634d5cef713762f0054f8 and 2 for PR HEAD eae4d7b3cfe9687d17a7d92bcc5ecc76f6f7c9c5 in total

openshift-ci-robot avatar Nov 13 '24 02:11 openshift-ci-robot

@lokanandaprabhu: Jira Issue OCPBUGS-38860: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38860 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-38860

Analysis / Root cause: From OCP 4.16, getting started section was changed to use expandable section of PatternFly and the removal option was removed.

Solution Description: Added removal option for getting started section in Add page of developer perspective and in Cluster overview page.

Screen shots / Gifs for design review:

https://github.com/user-attachments/assets/0f032e47-ea4c-4183-ac3b-4ef686c76518

Unit test coverage report: NA

Test setup:

  1. Go to Web console. Click on the "Getting started resources."
  2. Then you can expand and collapse this tab.
  3. But there is no option to directly remove this tab.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 13 '24 02:11 openshift-ci-robot

/cherrypick release-4.17

lokanandaprabhu avatar Nov 15 '24 04:11 lokanandaprabhu

@lokanandaprabhu: new pull request created: #14498

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.