console
console copied to clipboard
openshift
CONSOLE-4073, CONSOLE-4074: Address tech debt in CreateConfigSubform and UploadConfigSubform component
@nitin-dhevar: This pull request references CONSOLE-4073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@nitin-dhevar: This pull request references CONSOLE-4073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
This pull request references CONSOLE-4074 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
QE Approver /assign @yapei
Docs Approver: /assign @opayne1
PX Approver: /assign @reestr
tested the changes and no regression issues found
e2e-gcp-console is failing and it looks like we should either remove default JSON value or clear the content first then type in our test strings
{"auths":{"":{"username":"","password":"","email":""}}}
it looks like we have some issue saving uploaded file content because I see two options Save file(which is only expected for binary data or non-printable data? ) and Reveal/Hide values, but Reveal/Hide values doesn't show anything
https://github.com/user-attachments/assets/8bffb665-b23f-4f32-b0ee-ad844a9ffd93
[for comparison] If I create a Image Pull secret with the same file on a 4.18 cluster without PR changes, I can ONLY see Reveal/Hide values button
$ cat ~/Desktop/config.json
{
"auths": {
"quay.io": {},
"registry.ci.openshift.org": {}
},
"credsStore": "desktop"
}
@yapei I think this change actually fixed one bug and uncovered another. If you don't mind, could we address the newly discovered bug separately?
-
The bug we fixed in this refactor: Before this refactor, we were parsing then re-serializing file content whenever a file was uploaded through the "Upload configuration file" option. This was causing content to be modified. For instance, all whitespace is removed. This is not desirable behavior. We should retain parity with the original file content.
-
The bug this uncovered: Tab characters are being detected as "non-printable characters" in the Secret details view, causing the "Reveal/Hide" and "Save this file" actions to behave unexpectedly. We need to fix this logic for detecting binary or unprintable content since tab characters are printable.
I've opened a bug and PR to fix the issue: https://github.com/openshift/console/pull/14364
Thanks @TheRealJon no other issues and going to approve the PR /label qe-approved
@nitin-dhevar: This pull request references CONSOLE-4073 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
This pull request references CONSOLE-4074 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD 2dcaaab7a1d27ec269994a1ab5e0b9c462b115bc and 2 for PR HEAD 694038fd2cba2c2f6dd0aa69d1c467badf521cd4 in total
/retest-required
Remaining retests: 0 against base HEAD e748a31234ee5b33d4fc379be8259bc437a90faf and 1 for PR HEAD 694038fd2cba2c2f6dd0aa69d1c467badf521cd4 in total
/retest-required
Remaining retests: 0 against base HEAD e748a31234ee5b33d4fc379be8259bc437a90faf and 2 for PR HEAD 694038fd2cba2c2f6dd0aa69d1c467badf521cd4 in total
/retest-required
Remaining retests: 0 against base HEAD e748a31234ee5b33d4fc379be8259bc437a90faf and 2 for PR HEAD 694038fd2cba2c2f6dd0aa69d1c467badf521cd4 in total
/retest-required
Remaining retests: 0 against base HEAD e748a31234ee5b33d4fc379be8259bc437a90faf and 2 for PR HEAD 694038fd2cba2c2f6dd0aa69d1c467badf521cd4 in total
/retest-required
Remaining retests: 0 against base HEAD 186845a84dc53931e7a218f86be4bb355632c11d and 2 for PR HEAD 694038fd2cba2c2f6dd0aa69d1c467badf521cd4 in total
/retest-required
Remaining retests: 0 against base HEAD 186845a84dc53931e7a218f86be4bb355632c11d and 2 for PR HEAD 694038fd2cba2c2f6dd0aa69d1c467badf521cd4 in total
/retest-required
Remaining retests: 0 against base HEAD 267bc102474d3477b423d25daf072734079fc80e and 1 for PR HEAD 694038fd2cba2c2f6dd0aa69d1c467badf521cd4 in total
/retest-required
Remaining retests: 0 against base HEAD 267bc102474d3477b423d25daf072734079fc80e and 2 for PR HEAD 694038fd2cba2c2f6dd0aa69d1c467badf521cd4 in total
/retest-required
Remaining retests: 0 against base HEAD 267bc102474d3477b423d25daf072734079fc80e and 2 for PR HEAD 694038fd2cba2c2f6dd0aa69d1c467badf521cd4 in total
/retest-required
Remaining retests: 0 against base HEAD 267bc102474d3477b423d25daf072734079fc80e and 2 for PR HEAD 45bc8dc2ecf40ecf43c848f4c0e16374615d575b in total
@nitin-dhevar if you would like to merge this PR so that you retain authorship, it will need to be rebased. Otherwise, I will need to open a new PR, where I would retain your commits, but the you would lose PR authorship. Please let me know how you'd like to move forward.
I have rebased this PR, but I’m okay with creating a new PR too. Thank you @TheRealJon !
/retest-required
Remaining retests: 0 against base HEAD c673aff9ea6947ea70a5c39ea88ef2d4e24160fc and 2 for PR HEAD 70d6690ed6a4cd1f77829b1e1c2e5c3f9110b0a0 in total