console
console copied to clipboard
openshift
[WIP] CONSOLE-3970
@rhamilto: This pull request references CONSOLE-3970 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@rhamilto: This pull request references CONSOLE-3970 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
User can install Operators https://github.com/user-attachments/assets/eea22d29-611c-4bce-b523-7f948b1bb578
Dark mode https://github.com/user-attachments/assets/f8eb7099-9216-4b25-8d61-0df7fbb1acca
User preference to hide the button https://github.com/user-attachments/assets/169be67f-9c9d-4c8c-b90f-e48e36f18126
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@rhamilto: This pull request references CONSOLE-3970 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
User can install Operators
https://github.com/user-attachments/assets/eea22d29-611c-4bce-b523-7f948b1bb578
Dark mode
https://github.com/user-attachments/assets/f8eb7099-9216-4b25-8d61-0df7fbb1acca
User preference to hide the button
https://github.com/user-attachments/assets/169be67f-9c9d-4c8c-b90f-e48e36f18126
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@rhamilto: This pull request references CONSOLE-3970 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
User can install Operators
https://github.com/user-attachments/assets/eea22d29-611c-4bce-b523-7f948b1bb578
User cannot install Operators
Dark mode
https://github.com/user-attachments/assets/f8eb7099-9216-4b25-8d61-0df7fbb1acca
User preference to hide the button
https://github.com/user-attachments/assets/169be67f-9c9d-4c8c-b90f-e48e36f18126
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@rhamilto: This pull request references CONSOLE-3970 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
User can install Operators
https://github.com/user-attachments/assets/9fd42426-d709-4ff9-b9af-a16e6abbe740
User cannot install Operators
Dark mode
https://github.com/user-attachments/assets/f8eb7099-9216-4b25-8d61-0df7fbb1acca
User preference to hide the button
https://github.com/user-attachments/assets/169be67f-9c9d-4c8c-b90f-e48e36f18126
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@rhamilto: This pull request references CONSOLE-3970 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Includes changes from https://github.com/openshift/console/pull/14098
User can install Operators
https://github.com/user-attachments/assets/9fd42426-d709-4ff9-b9af-a16e6abbe740
User cannot install Operators
Dark mode
https://github.com/user-attachments/assets/f8eb7099-9216-4b25-8d61-0df7fbb1acca
User preference to hide the button
https://github.com/user-attachments/assets/169be67f-9c9d-4c8c-b90f-e48e36f18126
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
QE Approver /assign @yapei
Docs Approver: /assign @opayne1
PX Approver: /assign @reestr
@yapei, @opayne1, @reestr, please take a look. Want to make sure we have enough time for this to merge before branching on Friday.
QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @reestr
@rhamilto Tested on cluster launched against the pr. The Lightspeed button generally works with cluster admin user and normal user. There are small issues I want to discuss with you:
-
Too much blank on the top of modal after opening Lightspeed instruction modal, user need scroll down to see the "Install" button.
-
Some special role users, eg, give normal user the role 'cluster-reader' or 'cluster-status', user will see "Install" button on Lightspeed instruction modal, but will see access forbidden info on page after clicking install. I wonder if "Install" button should be replaced with suggestion info.
Thanks, @yanpzhan!
Too much blank on the top of modal after opening Lightspeed instruction modal, user need scroll down to see the "Install" button.
Updated to eliminate the margin above the logo if the viewport height is less than 1000px and a few other tweaks to the layout.
Some special role users, eg, give normal user the role 'cluster-reader' or 'cluster-status', user will see "Install" button on Lightspeed instruction modal, but will see access forbidden info on page after clicking install. I wonder if "Install" button should be replaced with suggestion info.
The install button is using the same permissions we use to show/hide the OperatorHub nav item.
@yanpzhan I agree with @rhamilto on being consistent on the permission checks 👍
Updated to eliminate the margin above the logo if the viewport height is less than 1000px and a few other tweaks to the layout.
@yanpzhan, it's also worth noting the content will be changing as the result of https://issues.redhat.com/browse/OCPBUGS-38051. I will tag you on that fix when it is up. Given feature freeze branching is occurring on Friday, we want to go ahead and merge this as is and update in a follow on.
@rhamilto Thanks for your update. There is not other concern now. Will track and follow on with the bug above. /label qe-approved
@rhamilto: This pull request references CONSOLE-3970 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Includes changes from https://github.com/openshift/console/pull/14098
User can install Operators
https://github.com/user-attachments/assets/9fd42426-d709-4ff9-b9af-a16e6abbe740
User cannot install Operators
Dark mode
https://github.com/user-attachments/assets/f8eb7099-9216-4b25-8d61-0df7fbb1acca
User preference to hide the button
https://github.com/user-attachments/assets/169be67f-9c9d-4c8c-b90f-e48e36f18126
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, rhamilto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jhadvig,rhamilto]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rhamilto: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.17.0-202408071315.p0.g1423a2a.assembly.stream.el9. All builds following this will include this PR.
