console icon indicating copy to clipboard operation
console copied to clipboard

ODC-7632: Combine Shipwright model pages

Open logonoff opened this issue 1 year ago • 11 comments
trafficstars

Fixes: https://issues.redhat.com/browse/ODC-7632

Solution Description:

I added the page

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/18614559/a65623d5-43d5-467a-885f-301100f6be80

Unit test coverage report:

n/a

Test setup:

Install Shipwright operator

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

logonoff avatar Jul 03 '24 13:07 logonoff

@logonoff: This pull request references ODC-7632 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Fixes: https://issues.redhat.com/browse/ODC-7632

Solution Description:

Screen shots / Gifs for design review:

Unit test coverage report:

Test setup:

Browser conformance:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 03 '24 13:07 openshift-ci-robot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jul 03 '24 13:07 openshift-ci[bot]

/jira refresh

logonoff avatar Jul 03 '24 13:07 logonoff

@logonoff: This pull request references ODC-7632 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 03 '24 13:07 openshift-ci-robot

@logonoff: This pull request references ODC-7632 which is a valid jira issue.

In response to this:

Fixes: https://issues.redhat.com/browse/ODC-7632

Solution Description:

I added the page

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/18614559/c8408733-0bf6-4556-95c0-48c30a458110

Unit test coverage report:

n/a

Test setup:

Install Shipwright operator

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 03 '24 15:07 openshift-ci-robot

/retest

logonoff avatar Jul 03 '24 20:07 logonoff

/retest

logonoff avatar Jul 04 '24 01:07 logonoff

@logonoff: This pull request references ODC-7632 which is a valid jira issue.

In response to this:

Fixes: https://issues.redhat.com/browse/ODC-7632

Solution Description:

I added the page

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/18614559/a65623d5-43d5-467a-885f-301100f6be80

Unit test coverage report:

n/a

Test setup:

Install Shipwright operator

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 04 '24 16:07 openshift-ci-robot

/retest

logonoff avatar Jul 05 '24 17:07 logonoff

/hold

@jhadvig Would require your approval on the new design for the Builds Nav Pane in the Admin Page

2024-07-08_18-37

Lucifergene avatar Jul 08 '24 13:07 Lucifergene

/cc @jhadvig

on request of @jerolimov @Lucifergene

logonoff avatar Jul 08 '24 13:07 logonoff

/retest

logonoff avatar Jul 08 '24 19:07 logonoff

/retest

logonoff avatar Jul 08 '24 23:07 logonoff

/cc @pankajshivpuje

vikram-raj avatar Jul 11 '24 13:07 vikram-raj

cc: @siamaksade

vikram-raj avatar Jul 11 '24 13:07 vikram-raj

/retest

logonoff avatar Jul 12 '24 14:07 logonoff

/unhold /retest

vikram-raj avatar Jul 17 '24 09:07 vikram-raj

@vikram-raj lgtm

pankajshivpuje avatar Jul 17 '24 13:07 pankajshivpuje

/label px-approved /label docs-approved

vikram-raj avatar Jul 18 '24 09:07 vikram-raj

/assign @sanketpathak

for qe-approved.

vikram-raj avatar Jul 18 '24 09:07 vikram-raj

/label tide/merge-method-squash

vikram-raj avatar Jul 18 '24 13:07 vikram-raj

/label tide/merge-method-squash

vikram-raj avatar Jul 22 '24 07:07 vikram-raj

Hi @logonoff , you need to run yarn i18n and then update the PR.

vikram-raj avatar Jul 22 '24 11:07 vikram-raj

/retest

vikram-raj avatar Jul 24 '24 10:07 vikram-raj

/remove-label tide/merge-method-squash

because I just squashed the commits

logonoff avatar Jul 24 '24 14:07 logonoff

/retest

logonoff avatar Jul 25 '24 14:07 logonoff

/retest

logonoff avatar Jul 25 '24 19:07 logonoff

/retest

logonoff avatar Jul 29 '24 19:07 logonoff

@logonoff The CI failure is due to this change you made here Screenshot 2024-07-30 at 4 27 09 PM

sanketpathak avatar Jul 30 '24 10:07 sanketpathak

/retest

logonoff avatar Jul 30 '24 20:07 logonoff