console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.16] OCPBUGS-36484: Revert - terminal: use username if uid is not present

Open openshift-cherrypick-robot opened this issue 1 year ago • 4 comments

This is an automated cherry-pick of #13719

/assign jhadvig

@openshift-cherrypick-robot: Jira Issue OCPBUGS-31685 has been cloned as Jira Issue OCPBUGS-36484. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-36484: Revert - terminal: use username if uid is not present

In response to this:

This is an automated cherry-pick of #13719

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 03 '24 09:07 openshift-ci-robot

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36484, which is invalid:

  • expected dependent Jira Issue OCPBUGS-31685 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #13719

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 03 '24 09:07 openshift-ci-robot

/label backport-risk-assessed /approved

jhadvig avatar Jul 08 '24 11:07 jhadvig

/jira refresh

jhadvig avatar Jul 08 '24 11:07 jhadvig

/approve

jhadvig avatar Jul 08 '24 11:07 jhadvig

@jhadvig: This pull request references Jira Issue OCPBUGS-36484, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-31685 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-31685 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 08 '24 11:07 openshift-ci-robot

@jhadvig is it possible to have this backport merged? It would help a lot with the QE testing for the upcoming Web Terminal 1.11 release. Thank you :)

AObuchow avatar Aug 01 '24 20:08 AObuchow

Tested on cluster launched against the pr, normal user and kubeadmin user could both open terminal successfully. /label qe-approved /label cherry-pick-approved

yanpzhan avatar Aug 02 '24 08:08 yanpzhan

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36484, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-31685 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-31685 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact: /cc @yapei

In response to this:

This is an automated cherry-pick of #13719

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 02 '24 08:08 openshift-ci-robot

/lgtm

jhadvig avatar Aug 07 '24 07:08 jhadvig

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 07 '24 07:08 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 96169cf25bbb168375af9a6123c437cf1871e0f4 and 2 for PR HEAD e9a5282f952ae61fbfaa0018458377372b6eab73 in total

openshift-ci-robot avatar Aug 07 '24 10:08 openshift-ci-robot

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 07 '24 13:08 openshift-ci[bot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36484: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36484 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #13719

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 07 '24 14:08 openshift-ci-robot

/cherry-pick release-4.15

jhadvig avatar Aug 07 '24 14:08 jhadvig

@jhadvig: new pull request created: #14114

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.16.0-202408071637.p0.g2b51e47.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Aug 07 '24 19:08 openshift-bot

Fix included in accepted release 4.16.0-0.nightly-2024-08-08-003631

openshift-merge-robot avatar Aug 08 '24 05:08 openshift-merge-robot