console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-32773: Values entered into the Instantiate Template form are automatically cleared

Open lokanandaprabhu opened this issue 1 year ago • 4 comments

Fixes: https://issues.redhat.com/browse/OCPBUGS-32773

Analysis / Root cause: The input fields are always populated based on the API response and user entered values are getting cleared out

Solution Description: Added the check to not load data after 1st load to keep user entered information

Screen shots / Gifs for design review:

---BEFORE---

https://github.com/openshift/console/assets/102503482/c42d654a-bceb-48cb-9add-08fc7584d0c6

---AFTER---

https://github.com/openshift/console/assets/102503482/d93f83b7-5d0b-463e-b1cf-542251655adf

Unit test coverage report: NA

Test setup:

  1. Log in with a non-administrator account.
  2. Select a template from the developer catalog and click on Instantiate Template.
  3. Enter values into the initially empty form.
  4. Wait for several seconds, and the entered values will disappear.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge

lokanandaprabhu avatar Jul 03 '24 07:07 lokanandaprabhu

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32773, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-32773

Analysis / Root cause: The input fields are always populated based on the API response and user entered values are getting cleared out

Solution Description: Added the check to not load data after 1st load to keep user entered information

Screen shots / Gifs for design review:

---BEFORE---

https://github.com/openshift/console/assets/102503482/c42d654a-bceb-48cb-9add-08fc7584d0c6

---AFTER---

https://github.com/openshift/console/assets/102503482/d93f83b7-5d0b-463e-b1cf-542251655adf

Unit test coverage report: NA

Test setup:

  1. Log in with a non-administrator account.
  2. Select a template from the developer catalog and click on Instantiate Template.
  3. Enter values into the initially empty form.
  4. Wait for several seconds, and the entered values will disappear.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 03 '24 07:07 openshift-ci-robot

/cc @vikram-raj @Lucifergene

lokanandaprabhu avatar Jul 03 '24 07:07 lokanandaprabhu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 13 '24 05:08 openshift-ci[bot]

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 13 '24 09:08 openshift-ci[bot]

@lokanandaprabhu: Jira Issue OCPBUGS-32773: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32773 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-32773

Analysis / Root cause: The input fields are always populated based on the API response and user entered values are getting cleared out

Solution Description: Added the check to not load data after 1st load to keep user entered information

Screen shots / Gifs for design review:

---BEFORE---

https://github.com/openshift/console/assets/102503482/c42d654a-bceb-48cb-9add-08fc7584d0c6

---AFTER---

https://github.com/openshift/console/assets/102503482/d93f83b7-5d0b-463e-b1cf-542251655adf

Unit test coverage report: NA

Test setup:

  1. Log in with a non-administrator account.
  2. Select a template from the developer catalog and click on Instantiate Template.
  3. Enter values into the initially empty form.
  4. Wait for several seconds, and the entered values will disappear.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 13 '24 09:08 openshift-ci-robot

/cherrypick release-4.17

lokanandaprabhu avatar Aug 13 '24 10:08 lokanandaprabhu

@lokanandaprabhu: new pull request created: #14143

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202408131314.p0.g721878e.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Aug 13 '24 14:08 openshift-bot