console icon indicating copy to clipboard operation
console copied to clipboard

Published 20 hours ago • verified publisher icon openshift

ODC-7621,ODC-7633: Add Shipwright as Build Options in Add & Edit Forms

Open Lucifergene opened this issue 1 year ago • 7 comments

Type:

  • [ ] Bug Fix
  • [x] New Feature

Jira Link:

  1. https://issues.redhat.com/browse/ODC-7621
  2. https://issues.redhat.com/browse/ODC-7633

Solution Description:

  • [x] Added SW Build Option
  • [x] Fixed Edit Forms

Screenshots / Videos for review:

Walkthrough:

https://github.com/openshift/console/assets/47265560/83ab139e-bc58-496f-a48a-d6a62b09b98a

Screenshots:

screencapture-localhost-9000-import-ns-test-2024-06-28-13_29_44

Screenshot from 2024-06-28 12-57-57

image

Test coverage:

  • [ ] Unit Tests Updated
  • [ ] E2E Tests Updated

Test setup:

  1. Install the Builds for Openshift operator (NOT THE SHIPWRIGHT OPERATOR AVAILABLE IN OPERATORHUB) If not available, execute this to install:
# Installing the Catalog Source for the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-catalog.yaml
# Wait till the operator is listed in Operatorhub
sleep 60
# Install the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-subscription.yaml
# Wait till the operator is properly installed
sleep 30
# Create SW CR
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/shipwright-build.yaml
# Wait for the SW CR to be created properly
sleep 20
# Install the ClusterBuildStrategies
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/buildah/buildah.yaml
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/source-to-image/source_to_image.yaml
  1. Use the Git Import Form with these URLs:
  • https://github.com/digitalocean/sample-nodejs - Builder Image Import Strategy - Port: 3000
  • https://github.com/Lucifergene/knative-do-demo - Dockerfile Import Strategy - Port: 5000
  1. Select Builds for Openshift (Shipwright) in the Build Options.
  2. Select the ClusterBuildStrategy
  3. Create the Application.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari

Lucifergene avatar Jun 28 '24 08:06 Lucifergene

@Lucifergene: This pull request references ODC-7621 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references ODC-7633 which is a valid jira issue.

In response to this:

Type:

  • [ ] Bug Fix
  • [x] New Feature

Jira Link:

  1. https://issues.redhat.com/browse/ODC-7621
  2. https://issues.redhat.com/browse/ODC-7633

Solution Description:

  • [ ] Added SW Build Option
  • [ ] Fixed Edit Forms

Screenshots / Videos for review:

Test coverage:

  • [ ] Unit Tests Updated
  • [ ] E2E Tests Updated

Test setup:

  1. Install the Builds for Openshift operator (NOT THE SHIPWRIGHT OPERATOR AVAILABLE IN OPERATORHUB) If not available, execute this to install:
# Installing the Catalog Source for the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-catalog.yaml
# Wait till the operator is listed in Operatorhub
sleep 60
# Install the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-subscription.yaml
# Wait till the operator is properly installed
sleep 30
# Create SW CR
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/shipwright-build.yaml
# Wait for the SW CR to be created properly
sleep 20
# Install the ClusterBuildStrategies
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/buildah/buildah.yaml
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/source-to-image/source_to_image.yaml
  1. Use the Git Import Form with these URLs:
  • https://github.com/digitalocean/sample-nodejs - Builder Image Import Strategy - Port: 3000
  • https://github.com/Lucifergene/knative-do-demo - Dockerfile Import Strategy - Port: 5000
  1. Select Builds for Openshift (Shipwright) in the Build Options.
  2. Select the ClusterBuildStrategy
  3. Create the Application.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 28 '24 08:06 openshift-ci-robot

@Lucifergene: This pull request references ODC-7621 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references ODC-7633 which is a valid jira issue.

In response to this:

Type:

  • [ ] Bug Fix
  • [x] New Feature

Jira Link:

  1. https://issues.redhat.com/browse/ODC-7621
  2. https://issues.redhat.com/browse/ODC-7633

Solution Description:

  • [ ] Added SW Build Option
  • [ ] Fixed Edit Forms

Screenshots / Videos for review:

Walkthrough:

https://github.com/openshift/console/assets/47265560/83ab139e-bc58-496f-a48a-d6a62b09b98a

Screenshots:

screencapture-localhost-9000-import-ns-test-2024-06-28-13_29_44

Screenshot from 2024-06-28 12-57-57

image

Test coverage:

  • [ ] Unit Tests Updated
  • [ ] E2E Tests Updated

Test setup:

  1. Install the Builds for Openshift operator (NOT THE SHIPWRIGHT OPERATOR AVAILABLE IN OPERATORHUB) If not available, execute this to install:
# Installing the Catalog Source for the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-catalog.yaml
# Wait till the operator is listed in Operatorhub
sleep 60
# Install the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-subscription.yaml
# Wait till the operator is properly installed
sleep 30
# Create SW CR
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/shipwright-build.yaml
# Wait for the SW CR to be created properly
sleep 20
# Install the ClusterBuildStrategies
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/buildah/buildah.yaml
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/source-to-image/source_to_image.yaml
  1. Use the Git Import Form with these URLs:
  • https://github.com/digitalocean/sample-nodejs - Builder Image Import Strategy - Port: 3000
  • https://github.com/Lucifergene/knative-do-demo - Dockerfile Import Strategy - Port: 5000
  1. Select Builds for Openshift (Shipwright) in the Build Options.
  2. Select the ClusterBuildStrategy
  3. Create the Application.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 28 '24 08:06 openshift-ci-robot

/cc @pankajshivpuje I have attached the SS of the Texts shown in the Form. Please review them if changes are needed.

Lucifergene avatar Jun 28 '24 08:06 Lucifergene

@Lucifergene: This pull request references ODC-7621 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references ODC-7633 which is a valid jira issue.

In response to this:

Type:

  • [ ] Bug Fix
  • [x] New Feature

Jira Link:

  1. https://issues.redhat.com/browse/ODC-7621
  2. https://issues.redhat.com/browse/ODC-7633

Solution Description:

  • [x] Added SW Build Option
  • [ ] Fixed Edit Forms

Screenshots / Videos for review:

Walkthrough:

https://github.com/openshift/console/assets/47265560/83ab139e-bc58-496f-a48a-d6a62b09b98a

Screenshots:

screencapture-localhost-9000-import-ns-test-2024-06-28-13_29_44

Screenshot from 2024-06-28 12-57-57

image

Test coverage:

  • [ ] Unit Tests Updated
  • [ ] E2E Tests Updated

Test setup:

  1. Install the Builds for Openshift operator (NOT THE SHIPWRIGHT OPERATOR AVAILABLE IN OPERATORHUB) If not available, execute this to install:
# Installing the Catalog Source for the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-catalog.yaml
# Wait till the operator is listed in Operatorhub
sleep 60
# Install the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-subscription.yaml
# Wait till the operator is properly installed
sleep 30
# Create SW CR
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/shipwright-build.yaml
# Wait for the SW CR to be created properly
sleep 20
# Install the ClusterBuildStrategies
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/buildah/buildah.yaml
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/source-to-image/source_to_image.yaml
  1. Use the Git Import Form with these URLs:
  • https://github.com/digitalocean/sample-nodejs - Builder Image Import Strategy - Port: 3000
  • https://github.com/Lucifergene/knative-do-demo - Dockerfile Import Strategy - Port: 5000
  1. Select Builds for Openshift (Shipwright) in the Build Options.
  2. Select the ClusterBuildStrategy
  3. Create the Application.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 28 '24 08:06 openshift-ci-robot

@Lucifergene The design changes look awesome. I have few recommendations for clarity and consistency.

  1. Consider changing 'Build Option' to 'Build option' (Word Option start with lower case letter) This should be for all the fields on the page if possible.
  2. Suggested support text for Build option drop list: 'Build Option to use for building the application', to 'Build option to use for transforming source code into a runnable container image'
  3. Consider moving 'Build for OpenShift (Shipwright)' as the first option in the drop list. So if other options are removed, the order doesn't change. Recommended support text for this option: Shipwright is an extensible framework for building container images on OpenShift Container Platform cluster.
  4. Consider moving 'Builds' as the 2nd option in the drop list. Change the 'Builds' to 'BuildConfig' The support text for the 'BuildConfig' option should be: Build configuration describes build definitions used for transforming source code into a runnable container image'
  5. Consider changing option 'Pipelines' to 'Build using pipelines' with support text to 'Buid using pipeline describes a process for transforming source code into a runnable container image' Pipelines support can be added using Red Hat OpenShift Pipelines Operator.

cc @siamaksade @alimobrem @beaumorley

pankajshivpuje avatar Jul 01 '24 16:07 pankajshivpuje

@Lucifergene: This pull request references ODC-7621 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references ODC-7633 which is a valid jira issue.

In response to this:

Type:

  • [ ] Bug Fix
  • [x] New Feature

Jira Link:

  1. https://issues.redhat.com/browse/ODC-7621
  2. https://issues.redhat.com/browse/ODC-7633

Solution Description:

  • [x] Added SW Build Option
  • [x] Fixed Edit Forms

Screenshots / Videos for review:

Walkthrough:

https://github.com/openshift/console/assets/47265560/83ab139e-bc58-496f-a48a-d6a62b09b98a

Screenshots:

screencapture-localhost-9000-import-ns-test-2024-06-28-13_29_44

Screenshot from 2024-06-28 12-57-57

image

Test coverage:

  • [x] Unit Tests Updated
  • [ ] E2E Tests Updated

Test setup:

  1. Install the Builds for Openshift operator (NOT THE SHIPWRIGHT OPERATOR AVAILABLE IN OPERATORHUB) If not available, execute this to install:
# Installing the Catalog Source for the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-catalog.yaml
# Wait till the operator is listed in Operatorhub
sleep 60
# Install the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-subscription.yaml
# Wait till the operator is properly installed
sleep 30
# Create SW CR
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/shipwright-build.yaml
# Wait for the SW CR to be created properly
sleep 20
# Install the ClusterBuildStrategies
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/buildah/buildah.yaml
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/source-to-image/source_to_image.yaml
  1. Use the Git Import Form with these URLs:
  • https://github.com/digitalocean/sample-nodejs - Builder Image Import Strategy - Port: 3000
  • https://github.com/Lucifergene/knative-do-demo - Dockerfile Import Strategy - Port: 5000
  1. Select Builds for Openshift (Shipwright) in the Build Options.
  2. Select the ClusterBuildStrategy
  3. Create the Application.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 09 '24 20:07 openshift-ci-robot

/lgtm

logonoff avatar Jul 11 '24 14:07 logonoff

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, Lucifergene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 11 '24 14:07 openshift-ci[bot]

/retest

Lucifergene avatar Jul 12 '24 06:07 Lucifergene

/label docs-approved /label px-approved

Lucifergene avatar Jul 15 '24 08:07 Lucifergene

@Lucifergene: This pull request references ODC-7621 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references ODC-7633 which is a valid jira issue.

In response to this:

Type:

  • [ ] Bug Fix
  • [x] New Feature

Jira Link:

  1. https://issues.redhat.com/browse/ODC-7621
  2. https://issues.redhat.com/browse/ODC-7633

Solution Description:

  • [x] Added SW Build Option
  • [x] Fixed Edit Forms

Screenshots / Videos for review:

Walkthrough:

https://github.com/openshift/console/assets/47265560/83ab139e-bc58-496f-a48a-d6a62b09b98a

Screenshots:

screencapture-localhost-9000-import-ns-test-2024-06-28-13_29_44

Screenshot from 2024-06-28 12-57-57

image

Test coverage:

  • [x] Unit Tests Updated

New E2E Tests will be added in the subsequent PR.

Test setup:

  1. Install the Builds for Openshift operator (NOT THE SHIPWRIGHT OPERATOR AVAILABLE IN OPERATORHUB) If not available, execute this to install:
# Installing the Catalog Source for the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-catalog.yaml
# Wait till the operator is listed in Operatorhub
sleep 60
# Install the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-subscription.yaml
# Wait till the operator is properly installed
sleep 30
# Create SW CR
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/shipwright-build.yaml
# Wait for the SW CR to be created properly
sleep 20
# Install the ClusterBuildStrategies
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/buildah/buildah.yaml
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/source-to-image/source_to_image.yaml
  1. Use the Git Import Form with these URLs:
  • https://github.com/digitalocean/sample-nodejs - Builder Image Import Strategy - Port: 3000
  • https://github.com/Lucifergene/knative-do-demo - Dockerfile Import Strategy - Port: 5000
  1. Select Builds for Openshift (Shipwright) in the Build Options.
  2. Select the ClusterBuildStrategy
  3. Create the Application.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 15 '24 08:07 openshift-ci-robot

/cc @sanketpathak Please give the qe-approval to this.

The E2E tests for this feature will be added in the next PR for the ticket: ODC-7634

Lucifergene avatar Jul 15 '24 08:07 Lucifergene

The links provided in the description don't work with non-admin user Screenshot 2024-07-15 at 5 39 14 PM

sanketpathak avatar Jul 15 '24 12:07 sanketpathak

@Lucifergene: This pull request references ODC-7621 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references ODC-7633 which is a valid jira issue.

In response to this:

Type:

  • [ ] Bug Fix
  • [x] New Feature

Jira Link:

  1. https://issues.redhat.com/browse/ODC-7621
  2. https://issues.redhat.com/browse/ODC-7633

Solution Description:

  • [x] Added SW Build Option
  • [x] Fixed Edit Forms

Screenshots / Videos for review:

Walkthrough:

https://github.com/openshift/console/assets/47265560/83ab139e-bc58-496f-a48a-d6a62b09b98a

Screenshots:

screencapture-localhost-9000-import-ns-test-2024-06-28-13_29_44

Screenshot from 2024-06-28 12-57-57

image

Test coverage:

  • [x] Unit Tests Updated

New E2E Tests will be added in the subsequent PR.

Test setup:

  1. Install the Builds for Openshift operator (NOT THE SHIPWRIGHT OPERATOR AVAILABLE IN OPERATORHUB) If not available, execute this to install:
# Installing the Catalog Source for the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-catalog.yaml
# Wait till the operator is listed in Operatorhub
sleep 60
# Install the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-subscription.yaml
# Wait till the operator is properly installed
sleep 30
# Create SW CR
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/shipwright-build.yaml
# Wait for the SW CR to be created properly
sleep 20
# Install the ClusterBuildStrategies
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/buildah/buildah.yaml
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/source-to-image/source_to_image.yaml
  1. Use the Git Import Form with these URLs:
  • https://github.com/digitalocean/sample-nodejs - Builder Image Import Strategy - Port: 3000
  • https://github.com/Lucifergene/knative-do-demo - Dockerfile Import Strategy - Port: 5000
  1. Select Builds for Openshift (Shipwright) in the Build Options.
  2. Select the ClusterBuildStrategy
  3. Create the Application.

Note: For testing as a Non-Admin user, make sure to give the user permission to get the "ClusterBuildStrategy" resource, otherwise you wont be able to use the Shipwright Build at all.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 15 '24 12:07 openshift-ci-robot

The links provided in the description don't work with non-admin user Screenshot 2024-07-15 at 5 39 14 PM

For testing as a Non-Admin user, give the user, permission to get the "ClusterBuildStrategy" resource. Create a role that gives this permission and attach it to the user via RoleBinding.

Lucifergene avatar Jul 15 '24 12:07 Lucifergene

Verified on a cluster with admin user and non-admin user with permission /label qe-approved

sanketpathak avatar Jul 17 '24 09:07 sanketpathak

@Lucifergene: This pull request references ODC-7621 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references ODC-7633 which is a valid jira issue.

In response to this:

Type:

  • [ ] Bug Fix
  • [x] New Feature

Jira Link:

  1. https://issues.redhat.com/browse/ODC-7621
  2. https://issues.redhat.com/browse/ODC-7633

Solution Description:

  • [x] Added SW Build Option
  • [x] Fixed Edit Forms

Screenshots / Videos for review:

Walkthrough:

https://github.com/openshift/console/assets/47265560/83ab139e-bc58-496f-a48a-d6a62b09b98a

Screenshots:

screencapture-localhost-9000-import-ns-test-2024-06-28-13_29_44

Screenshot from 2024-06-28 12-57-57

image

Test coverage:

  • [x] Unit Tests Updated

New E2E Tests will be added in the subsequent PR.

Test setup:

  1. Install the Builds for Openshift operator (NOT THE SHIPWRIGHT OPERATOR AVAILABLE IN OPERATORHUB) If not available, execute this to install:
# Installing the Catalog Source for the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-catalog.yaml
# Wait till the operator is listed in Operatorhub
sleep 60
# Install the operator
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/builds-subscription.yaml
# Wait till the operator is properly installed
sleep 30
# Create SW CR
oc apply -f https://github.com/openshift-dev-console/operator-subscriptions/raw/main/shipwright-build.yaml
# Wait for the SW CR to be created properly
sleep 20
# Install the ClusterBuildStrategies
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/buildah/buildah.yaml
oc apply -f https://github.com/redhat-developer/openshift-builds-catalog/raw/main/clusterBuildStrategy/source-to-image/source_to_image.yaml
  1. Use the Git Import Form with these URLs:
  • https://github.com/digitalocean/sample-nodejs - Builder Image Import Strategy - Port: 3000
  • https://github.com/Lucifergene/knative-do-demo - Dockerfile Import Strategy - Port: 5000
  1. Select Builds for Openshift (Shipwright) in the Build Options.
  2. Select the ClusterBuildStrategy
  3. Create the Application.

Note: For testing as a Non-Admin user, make sure to give the user permission to get the "ClusterBuildStrategy" resource, otherwise you wont be able to use the Shipwright Build at all.

Browser conformance:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 17 '24 09:07 openshift-ci-robot

/label acknowledge-critical-fixes-only

vikram-raj avatar Jul 17 '24 09:07 vikram-raj

/retest-required

Remaining retests: 0 against base HEAD c4a222d870089b925d0a8e04cedca5ca9fcb4f7e and 2 for PR HEAD a16cecbcf6ea8020132841873d5cd76cf20ae38c in total

openshift-ci-robot avatar Jul 17 '24 12:07 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD ec62f1b7d7d3d9d241c2a0a556173b9b12a274a9 and 1 for PR HEAD a16cecbcf6ea8020132841873d5cd76cf20ae38c in total

openshift-ci-robot avatar Jul 17 '24 15:07 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 8b0c110676ed784183cbd510ed66ff1b4efe63aa and 0 for PR HEAD a16cecbcf6ea8020132841873d5cd76cf20ae38c in total

openshift-ci-robot avatar Jul 18 '24 00:07 openshift-ci-robot

/hold

Revision a16cecbcf6ea8020132841873d5cd76cf20ae38c was retested 3 times: holding

openshift-ci-robot avatar Jul 18 '24 01:07 openshift-ci-robot

/unhold /retest

Lucifergene avatar Jul 18 '24 06:07 Lucifergene

@Lucifergene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 18 '24 12:07 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202407181511.p0.g385a3e3.assembly.stream.el9 for distgit openshift-enterprise-console. All builds following this will include this PR.

openshift-bot avatar Jul 18 '24 16:07 openshift-bot

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.17.0-202407191642.p0.g385a3e3.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Jul 19 '24 18:07 openshift-bot