ODC-7620: Modal submit button: show loading state

[logonoff]

trafficstars

Fixes:

https://issues.redhat.com/browse/ODC-7620

Solution Description:

I noticed that modals are not affected by the previous PR #13959, this PR applies the same change to modals

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/18614559/39695775-a692-42e4-9d41-c27b2fecad51

Unit test coverage report:

Unchanged

Test setup:

n/a

Browser conformance:

• [x] Chrome
• [x] Firefox
• [ ] Safari

[openshift-ci-robot]

@logonoff: This pull request references ODC-7620 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7620

Solution Description:

I noticed that modals are not affected by the previous PR #13959, this PR applies the same change to modals

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/18614559/39695775-a692-42e4-9d41-c27b2fecad51

Unit test coverage report:

Unchanged

Test setup:

n/a

Browser conformance:

• [x] Chrome
• [x] Firefox
• [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/jira refresh

[openshift-ci-robot]

@logonoff: This pull request references ODC-7620 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vikram-raj]

It will affect the Admin perspective as well. So, better to get +1 from @jhadvig.

Context: In dev console, we updated the all forms submit button with pf progress indicator in the button itself instead of the inline indicator below the button.

This PR adding the progress indicator to the modal submit button will affect the admin perspective as we are using the same modal component in both perspectives.

@jhadvig are you fine with this change?

[jhadvig]

@vikram-raj the change looks good to me 👍 Glad we are able to use the PF components for this.

[vikram-raj]

propagated from the epic /label docs-approved /label px-approved

[vikram-raj]

/assign @sanketpathak for the qe-approved

[openshift-ci[bot]]

@vikram-raj: GitHub didn't allow me to assign the following users: for, the, qe-approved.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @sanketpathak for the qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~frontend/OWNERS~~ [vikram-raj]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[sanketpathak]

Verified on a cluster with admin and non-admin user

https://github.com/openshift/console/assets/10252230/48b17131-66a2-4ff9-92df-a93a1daca0c4

/label qe-approved

[openshift-ci-robot]

@logonoff: This pull request references ODC-7620 which is a valid jira issue.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7620

Solution Description:

I noticed that modals are not affected by the previous PR #13959, this PR applies the same change to modals

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/18614559/39695775-a692-42e4-9d41-c27b2fecad51

Unit test coverage report:

Unchanged

Test setup:

n/a

Browser conformance:

• [x] Chrome
• [x] Firefox
• [ ] Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ec2298cefecdecdc9a7511bbcfe78875d3fcb1dd and 2 for PR HEAD 274a0c28a12e24dfe4432b91d4a37ef9d6d10bac in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 649af93d7cb60e7cd9007c4a9a69ef74ec791680 and 1 for PR HEAD 274a0c28a12e24dfe4432b91d4a37ef9d6d10bac in total