console
console copied to clipboard
ODC-7623: Persist previously opened tab in Builds Page
Fixes:
https://issues.redhat.com/browse/ODC-7623
Solution Description:
In addition to checking for shipwright and redirecting, we also check for the currently opened tab and save it.
Screen shots / Gifs for design review:
https://github.com/openshift/console/assets/18614559/d332f970-7fe5-4f6b-804f-f2938ae328ad
Unit test coverage report:
unchanged
Test setup:
Set up Shipwright operator
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
/cc @vikram-raj /cc @Lucifergene
@logonoff: This pull request references ODC-7623 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Fixes:
https://issues.redhat.com/browse/ODC-7623
Solution Description:
In addition to checking for shipwright and redirecting, we also check for the currently opened tab and save it.
Screen shots / Gifs for design review:
https://github.com/openshift/console/assets/18614559/d332f970-7fe5-4f6b-804f-f2938ae328ad
Unit test coverage report:
unchanged
Test setup:
Set up Shipwright operator
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
/cc @vikram-raj /cc @Lucifergene
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/lgtm
/retest
/hold
/unhold
/hold
Tests are running green
/retest
@logonoff: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/label docs-approved /label px-approved /label qe-approved
@logonoff: This pull request references ODC-7623 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Fixes:
https://issues.redhat.com/browse/ODC-7623
Solution Description:
In addition to checking for shipwright and redirecting, we also check for the currently opened tab and save it.
Screen shots / Gifs for design review:
https://github.com/openshift/console/assets/18614559/d332f970-7fe5-4f6b-804f-f2938ae328ad
Unit test coverage report:
unchanged
Test setup:
Set up Shipwright operator
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
/cc @vikram-raj /cc @Lucifergene
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: logonoff, lokanandaprabhu, Lucifergene
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/dev-console/OWNERS~~ [Lucifergene,lokanandaprabhu]
- ~~frontend/packages/shipwright-plugin/integration-tests/OWNERS~~ [Lucifergene,lokanandaprabhu]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[ART PR BUILD NOTIFIER]
This PR has been included in build openshift-enterprise-console-container-v4.17.0-202407121043.p0.g6cfb435.assembly.stream.el9 for distgit openshift-enterprise-console. All builds following this will include this PR.