console icon indicating copy to clipboard operation
console copied to clipboard

ODC-7623: Persist previously opened tab in Builds Page

Open logonoff opened this issue 1 year ago • 8 comments
trafficstars

Fixes:

https://issues.redhat.com/browse/ODC-7623

Solution Description:

In addition to checking for shipwright and redirecting, we also check for the currently opened tab and save it.

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/18614559/d332f970-7fe5-4f6b-804f-f2938ae328ad

Unit test coverage report:

unchanged

Test setup:

Set up Shipwright operator

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

/cc @vikram-raj /cc @Lucifergene

logonoff avatar Jun 25 '24 15:06 logonoff

@logonoff: This pull request references ODC-7623 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7623

Solution Description:

In addition to checking for shipwright and redirecting, we also check for the currently opened tab and save it.

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/18614559/d332f970-7fe5-4f6b-804f-f2938ae328ad

Unit test coverage report:

unchanged

Test setup:

Set up Shipwright operator

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

/cc @vikram-raj /cc @Lucifergene

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 25 '24 15:06 openshift-ci-robot

/lgtm

lokanandaprabhu avatar Jun 27 '24 09:06 lokanandaprabhu

/retest

logonoff avatar Jun 27 '24 16:06 logonoff

/hold

Lucifergene avatar Jul 04 '24 07:07 Lucifergene

/unhold

logonoff avatar Jul 04 '24 20:07 logonoff

/hold

The-Anton avatar Jul 08 '24 09:07 The-Anton

Tests are running green

Screenshot 2024-07-11 at 7 30 25 PM

The-Anton avatar Jul 11 '24 14:07 The-Anton

/retest

logonoff avatar Jul 11 '24 17:07 logonoff

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 11 '24 18:07 openshift-ci[bot]

/label docs-approved /label px-approved /label qe-approved

The-Anton avatar Jul 12 '24 04:07 The-Anton

@logonoff: This pull request references ODC-7623 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7623

Solution Description:

In addition to checking for shipwright and redirecting, we also check for the currently opened tab and save it.

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/18614559/d332f970-7fe5-4f6b-804f-f2938ae328ad

Unit test coverage report:

unchanged

Test setup:

Set up Shipwright operator

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari

/cc @vikram-raj /cc @Lucifergene

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 12 '24 04:07 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, lokanandaprabhu, Lucifergene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 12 '24 08:07 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202407121043.p0.g6cfb435.assembly.stream.el9 for distgit openshift-enterprise-console. All builds following this will include this PR.

openshift-bot avatar Jul 12 '24 11:07 openshift-bot