console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-16141: Fix ArtifactHub integration e2e test

Open logonoff opened this issue 1 year ago • 8 comments
trafficstars

Fixes:

https://issues.redhat.com/browse/OCPBUGS-16141

Analysis / Root cause:

The git-clone information in ArtifactHub probably wasn't done loading yet as cypress clicks on it quickly

Solution Description:

Disable the add button until it loads

Screen shots / Gifs for design review:

image

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari

Additional notes:

logonoff avatar Jun 17 '24 20:06 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-16141, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-16141

Analysis / Root cause:

The git-clone information in ArtifactHub probably wasn't done loading yet since cypress interacts with the console so fast, which I think is why running the same querySelectors manually worked

Solution Description:

Add a 1 second wait between steps

Screen shots / Gifs for design review:

image

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari

Additional notes:

The root cause of this should probably be looked into..

/cc @vikram-raj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 17 '24 20:06 openshift-ci-robot

/jira refresh

logonoff avatar Jun 17 '24 20:06 logonoff

@logonoff: This pull request references Jira Issue OCPBUGS-16141, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 17 '24 20:06 openshift-ci-robot

@logonoff: This pull request references Jira Issue OCPBUGS-16141, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-16141

Analysis / Root cause:

The git-clone information in ArtifactHub probably wasn't done loading yet, since cypress interacts with the console so fast. This is likely why running the same querySelectors manually worked

Solution Description:

Add a 1 second wait between selecting the git-clone ArtifactHub item and clicking Add and install

Screen shots / Gifs for design review:

image

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari

Additional notes:

The root cause of this should probably be looked into..

/cc @vikram-raj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 17 '24 20:06 openshift-ci-robot

/assign @sanketpathak

vikram-raj avatar Jun 19 '24 15:06 vikram-raj

/retest

Lucifergene avatar Aug 07 '24 13:08 Lucifergene

Test case is running green Screenshot from 2024-11-05 17-13-58 /lgtm

sanketpathak avatar Nov 05 '24 14:11 sanketpathak

/retest

logonoff avatar Nov 05 '24 16:11 logonoff

/retest

logonoff avatar Nov 05 '24 20:11 logonoff

/label tide/merge-method-squash

Lucifergene avatar Nov 06 '24 08:11 Lucifergene

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, Lucifergene, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 06 '24 08:11 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 1533f64dd3fcf233864f5dc9820ed9d619fa835d and 2 for PR HEAD 3909b029e6b02ed52e3331a9aee8840dde02bf82 in total

openshift-ci-robot avatar Nov 06 '24 09:11 openshift-ci-robot

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 06 '24 16:11 openshift-ci[bot]

@logonoff: Jira Issue OCPBUGS-16141: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16141 has been moved to the MODIFIED state.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-16141

Analysis / Root cause:

The git-clone information in ArtifactHub probably wasn't done loading yet as cypress clicks on it quickly

Solution Description:

Disable the add button until it loads

Screen shots / Gifs for design review:

image

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari

Additional notes:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 06 '24 16:11 openshift-ci-robot

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411061940.p0.g2bce638.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Nov 06 '24 21:11 openshift-bot