console
console copied to clipboard
ODC-7623: Set Shipwright Builds as the default tab in Builds Page if the operator is installed
Fixes: https://issues.redhat.com/browse/ODC-7623
Solution Description: Set Shipwright Builds as the default tab in Builds Page if the operator is installed
Screen shots / Gifs for design review:
https://github.com/openshift/console/assets/47265560/073a6a84-de79-478a-8090-8765f963dd5d
Unit test coverage report:
- [x] E2E Tests Updated
Test setup:
- Install the Shipwright Builds operator
- Go to the Builds Page.
- You will see that Shipwright Builds tab is selected by default
Browser conformance:
- [x] Chrome
- [ ] Firefox
@Lucifergene: This pull request references ODC-7623 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Fixes: https://issues.redhat.com/browse/ODC-7623
Solution Description: Set Shipwright Builds as the default tab in Builds Page if the operator is installed
Screen shots / Gifs for design review:
https://github.com/openshift/console/assets/47265560/073a6a84-de79-478a-8090-8765f963dd5d
Unit test coverage report:
- [x] E2E Tests Updated
Test setup:
- Install the Shipwright Builds operator
- Go to the Builds Page.
- You will see that Shipwright Builds tab is selected by default
Browser conformance:
- [x] Chrome
- [ ] Firefox
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@siamaksade Wanted to get your acknowledgement for this. This will auto-select the "Shipwright Builds" Tab in the Builds Navigation Page when Shipwright is installed in the cluster. This can save a click for users who primarily want to interact with Shipwright Builds once they have installed the operator.
/retest
Tested locally. Working fine.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lokanandaprabhu, Lucifergene
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/dev-console/OWNERS~~ [Lucifergene,lokanandaprabhu]
- ~~frontend/packages/shipwright-plugin/integration-tests/OWNERS~~ [Lucifergene,lokanandaprabhu]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/label docs-approved /label px-approved
/retest
/retest
/retest
@Lucifergene: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-gcp-console | ba0e676c84a412bce15f82fa738a029c17fa5d38 | link | true | /test e2e-gcp-console |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/hold
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.