console icon indicating copy to clipboard operation
console copied to clipboard

ODC-7623: Set Shipwright Builds as the default tab in Builds Page if the operator is installed

Open Lucifergene opened this issue 1 year ago • 10 comments

Fixes: https://issues.redhat.com/browse/ODC-7623

Solution Description: Set Shipwright Builds as the default tab in Builds Page if the operator is installed

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/47265560/073a6a84-de79-478a-8090-8765f963dd5d

Unit test coverage report:

  • [x] E2E Tests Updated

Test setup:

  1. Install the Shipwright Builds operator
  2. Go to the Builds Page.
  3. You will see that Shipwright Builds tab is selected by default

Browser conformance:

  • [x] Chrome
  • [ ] Firefox

Lucifergene avatar Jun 13 '24 21:06 Lucifergene

@Lucifergene: This pull request references ODC-7623 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Fixes: https://issues.redhat.com/browse/ODC-7623

Solution Description: Set Shipwright Builds as the default tab in Builds Page if the operator is installed

Screen shots / Gifs for design review:

https://github.com/openshift/console/assets/47265560/073a6a84-de79-478a-8090-8765f963dd5d

Unit test coverage report:

  • [x] E2E Tests Updated

Test setup:

  1. Install the Shipwright Builds operator
  2. Go to the Builds Page.
  3. You will see that Shipwright Builds tab is selected by default

Browser conformance:

  • [x] Chrome
  • [ ] Firefox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 13 '24 21:06 openshift-ci-robot

@siamaksade Wanted to get your acknowledgement for this. This will auto-select the "Shipwright Builds" Tab in the Builds Navigation Page when Shipwright is installed in the cluster. This can save a click for users who primarily want to interact with Shipwright Builds once they have installed the operator.

Lucifergene avatar Jun 14 '24 09:06 Lucifergene

/retest

Lucifergene avatar Jun 14 '24 09:06 Lucifergene

Tested locally. Working fine.

/lgtm

lokanandaprabhu avatar Jun 14 '24 11:06 lokanandaprabhu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, Lucifergene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 14 '24 11:06 openshift-ci[bot]

/label docs-approved /label px-approved

Lucifergene avatar Jun 20 '24 10:06 Lucifergene

/retest

Lucifergene avatar Jun 20 '24 10:06 Lucifergene

/retest

Lucifergene avatar Jun 24 '24 08:06 Lucifergene

/retest

vikram-raj avatar Jul 02 '24 11:07 vikram-raj

@Lucifergene: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console ba0e676c84a412bce15f82fa738a029c17fa5d38 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 02 '24 15:07 openshift-ci[bot]

/hold

Lucifergene avatar Jul 12 '24 06:07 Lucifergene

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Jul 12 '24 06:07 openshift-merge-robot