console
console copied to clipboard
openshift
OCPBUGS-34764: Ensure envs are initted upon first load
Fixes:
Maps with JIRA issue https://issues.redhat.com/browse/OCPBUGS-34764
Analysis / Root cause:
There is a data race between the environment variable editor component (which only takes the initial value) and the knative yaml parser. The env variable component loads first which sets the initial value as blank since the parser is still working. Then the parser is done, updates the prop, but is ignored because the env variable component is already loaded. This also fixes the issue...
Solution Description:
Block the env selector from loading until the func.yaml is finished fetching and parsing
Screen shots / Gifs for design review:
n/a
Unit test coverage report:
unchanged
Test setup:
Install the Red Hat OpenShift Serverless and setup a Knative service
Then use @Lucifergene 's serverless example https://github.com/Lucifergene/oc-func
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
@logonoff: This pull request references Jira Issue OCPBUGS-34764, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.17.0) matches configured target version for branch (4.17.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Fixes:
Maps with JIRA issue https://issues.redhat.com/browse/OCPBUGS-34764
Analysis / Root cause:
While the env variables are being correctly parsed, this information is not being passed to the component rendering the env field
Solution Description:
Screen shots / Gifs for design review:
n/a
Unit test coverage report:
unchanged
Test setup:
Used @Lucifergene 's serverless example https://github.com/Lucifergene/oc-func
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@logonoff: This pull request references Jira Issue OCPBUGS-34764, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.17.0) matches configured target version for branch (4.17.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
In response to this:
Fixes:
Maps with JIRA issue https://issues.redhat.com/browse/OCPBUGS-34764
Analysis / Root cause:
While the env variables are being correctly parsed, this information is not being passed to the component rendering the env field
Solution Description:
Screen shots / Gifs for design review:
n/a
Unit test coverage report:
unchanged
Test setup:
Install the Red Hat OpenShift Serverless and setup a Knative service
Then use @Lucifergene 's serverless example https://github.com/Lucifergene/oc-func
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@logonoff Please add Unit & E2E tests once completed to prevent the issue resurface again later on :)
Thanks for this bug fix! The Frontend tests are failing. You would need to fix the Frontend Unit Tests of all the forms that are using the schema you have updated. Once you fix those, you might also see the E2E tests failing for DevConsole. Need to fix those as well.
/cc @sanketpathak for any queries regarding the e2e tests as its affecting the main E2E.
/retest-required
Remaining retests: 0 against base HEAD 4351a55df1cc8d87af4f8ad4f8afc3627ea4ac15 and 2 for PR HEAD 66a673861c0f8b9c23457aad4ee8a8c409ea594e in total
/retest-required
Remaining retests: 0 against base HEAD 4351a55df1cc8d87af4f8ad4f8afc3627ea4ac15 and 2 for PR HEAD 66a673861c0f8b9c23457aad4ee8a8c409ea594e in total
/retest-required
Remaining retests: 0 against base HEAD 4351a55df1cc8d87af4f8ad4f8afc3627ea4ac15 and 2 for PR HEAD 66a673861c0f8b9c23457aad4ee8a8c409ea594e in total
/retest-required
Remaining retests: 0 against base HEAD af11c82c494d122a3fecca5ca364e85e1db9bd05 and 2 for PR HEAD 66a673861c0f8b9c23457aad4ee8a8c409ea594e in total
/retest-required
Remaining retests: 0 against base HEAD ae8180c788ef40b62e506712dd6274a9bc76464a and 2 for PR HEAD 66a673861c0f8b9c23457aad4ee8a8c409ea594e in total
/retest-required
Remaining retests: 0 against base HEAD ae8180c788ef40b62e506712dd6274a9bc76464a and 2 for PR HEAD 66a673861c0f8b9c23457aad4ee8a8c409ea594e in total
/retest-required
Remaining retests: 0 against base HEAD 7efe9105b4d34c50c377789ba5e32f9c8d224724 and 1 for PR HEAD 66a673861c0f8b9c23457aad4ee8a8c409ea594e in total
/retest-required
Remaining retests: 0 against base HEAD 7efe9105b4d34c50c377789ba5e32f9c8d224724 and 2 for PR HEAD 66a673861c0f8b9c23457aad4ee8a8c409ea594e in total
/retest-required
Remaining retests: 0 against base HEAD 46a28bad8f300acb589c11e075bdeb065f452290 and 2 for PR HEAD 66a673861c0f8b9c23457aad4ee8a8c409ea594e in total
/retest-required
Remaining retests: 0 against base HEAD e7a7c24c827497fb3fc1f654ba86ec62a2581de2 and 1 for PR HEAD 66a673861c0f8b9c23457aad4ee8a8c409ea594e in total
@logonoff: This pull request references Jira Issue OCPBUGS-34764, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.18.0) matches configured target version for branch (4.18.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sanketpathak
In response to this:
Fixes:
Maps with JIRA issue https://issues.redhat.com/browse/OCPBUGS-34764
Analysis / Root cause:
There is a data race between the environment variable editor component (which only takes the initial value) and the knative yaml parser. The env variable component loads first which sets the initial value as blank since the parser is still working. Then the parser is done, updates the prop, but is ignored because the env variable component is already loaded.
Delaying loading the env list for 1 second also fixes the issue...
Solution Description:
Block the env selector from loading until the func.yaml is finished fetching and parsing
Screen shots / Gifs for design review:
n/a
Unit test coverage report:
unchanged
Test setup:
Install the Red Hat OpenShift Serverless and setup a Knative service
Then use @Lucifergene 's serverless example https://github.com/Lucifergene/oc-func
Browser conformance:
- [x] Chrome
- [x] Firefox
- [ ] Safari
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: logonoff, Lucifergene, sanketpathak, vikram-raj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [vikram-raj]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 253f7e2846fc81f26dd0fdb33a58ba4eb9731e76 and 2 for PR HEAD 906b99c874a41864960e75d7ccbde7d6c2a29546 in total