openshift
Hash or encode controller.devfile.io/creator label when backend validates Web Terminal creator
With https://github.com/openshift/console/commit/e87dc6fc852d23e8fca211cd0d3862b07cefa79e, the OpenShift console expects the controller.devfile.io/creator label on a Web Terminal DevWorkspace to be the users username if they do not have a UID (as is the case for kubeadmin). However, certain characters permitted in usernames are not valid Kubernetes label values.
Thus, changes must be made to the OpenShift Console backend to expect a different value for the controller.devfile.io/creator label. A possible option is to SHA256 hash the username and obtain the hex representation as the expected controller.devfile.io/creator label value. A similar approach was used in the usersettings code.
Another potential option is to use Base32 encoding with an alternate padding character instead of = (which is not a valid character for Kubernetes labels) and change all characters in the encoding to lower case. Unlike Base64, Base32 does not mix lower and upper case characters.
Still, taking a similar approach to the usersettings code of hashing the username would be more consistent and is probably prefferable.
Additional Context
This is a blocker for https://github.com/openshift/console/issues/13696, and a follow-up on an earlier comment of mine..
Whichever hashing or encoding process for the username is used must also be adopted in the DevWorkspace Operator which is responsible for adding the controller.devfile.io/creator label on Web Terminal DevWorkspaces: https://github.com/devfile/devworkspace-operator/issues/1245
Note: the usersettings code makes a special case for kube:admin and simply uses the value kubeadmin instead of its hashed-then-hex'ed representation. I'm not sure if there was a particular reason for this (was it due to pre-existing code?) and whether it needs to be considered for this issue. CC: @stlaz
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
This issue is now no longer required, see https://github.com/redhat-developer/web-terminal-operator/issues/162#issuecomment-2206400246