console
console copied to clipboard
openshift
OCPBUGS-29479: fix asynccache improper initialization
There were two bugs in the async cache initialization:
- the initialization never returns an error even if it fails to run the caching function
- The context in the caching function is cancelled right after the polling returns. If the cached item makes use of the context (OIDC providers unfortunately do), it will start failing.
/assign @TheRealJon /cc @jhadvig
@stlaz: This pull request references Jira Issue OCPBUGS-29479, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
There were two bugs in the async cache initialization:
- the initialization never returns an error even if it fails to run the caching function
- The context in the caching function is cancelled right after the polling returns. If the cached item makes use of the context (OIDC providers unfortunately do), it will start failing.
/assign @TheRealJon /cc @jhadvig
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: stlaz, TheRealJon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/OWNERS~~ [TheRealJon]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 0 against base HEAD e6c6f53e90bf64f36f40640807836fb994c51b1b and 2 for PR HEAD 68f2a46d1a94f7fe90822aa194eed77f6f16e862 in total
/retest-required
Remaining retests: 0 against base HEAD 56ad07201bb0cbf980d0321cf0cd290a09e58c10 and 1 for PR HEAD 68f2a46d1a94f7fe90822aa194eed77f6f16e862 in total
/retest-required
Remaining retests: 0 against base HEAD 838699a0518afb93a13129272ff3dcde79e42176 and 0 for PR HEAD 68f2a46d1a94f7fe90822aa194eed77f6f16e862 in total
@stlaz: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@stlaz: Jira Issue OCPBUGS-29479: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-29479 has been moved to the MODIFIED state.
In response to this:
There were two bugs in the async cache initialization:
- the initialization never returns an error even if it fails to run the caching function
- The context in the caching function is cancelled right after the polling returns. If the cached item makes use of the context (OIDC providers unfortunately do), it will start failing.
/assign @TheRealJon /cc @jhadvig
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[ART PR BUILD NOTIFIER]
This PR has been included in build openshift-enterprise-console-container-v4.16.0-202403290911.p0.g537716b.assembly.stream.el9 for distgit openshift-enterprise-console. All builds following this will include this PR.
Fix included in accepted release 4.16.0-0.nightly-2024-03-30-033956
@stlaz: #13703 failed to apply on top of branch "release-4.15":
Applying: auth: add unit tests for the async cache
Applying: cosmetic: move asynccache to its own package
Applying: fix asynccache never returning an error
Using index info to reconstruct a base tree...
M pkg/serverutils/asynccache/asynccache.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/serverutils/asynccache/asynccache.go
CONFLICT (content): Merge conflict in pkg/serverutils/asynccache/asynccache.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 fix asynccache never returning an error
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherry-pick release-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
