console icon indicating copy to clipboard operation
console copied to clipboard

CONSOLE-3883: Improve local plugin development docs

Open vojtechszocs opened this issue 1 year ago • 17 comments
trafficstars

  • revisit the section on local plugin development
  • add section on using local plugin SDK code
  • add section on changes in Console provided shared modules

vojtechszocs avatar Mar 18 '24 18:03 vojtechszocs

@vojtechszocs: This pull request references CONSOLE-3883 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

  • revisit the section on local plugin development
  • add section on using local plugin SDK code
  • add section on changes in Console provided shared modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 18 '24 18:03 openshift-ci-robot

cc @opayne1

vojtechszocs avatar Mar 18 '24 18:03 vojtechszocs

/retest

vojtechszocs avatar Mar 19 '24 13:03 vojtechszocs

/retest

christoph-jerolimov avatar Mar 19 '24 16:03 christoph-jerolimov

/label acknowledge-critical-fixes-only

rhamilto avatar Mar 19 '24 23:03 rhamilto

QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @RickJWagner

rhamilto avatar Mar 19 '24 23:03 rhamilto

the doc changes look good to us /label qe-approved

yapei avatar Mar 20 '24 06:03 yapei

@vojtechszocs: This pull request references CONSOLE-3883 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

  • revisit the section on local plugin development
  • add section on using local plugin SDK code
  • add section on changes in Console provided shared modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 20 '24 06:03 openshift-ci-robot

Thank you for these docs improvements. Docs are the public face of our products, very important for customers and Red Hatters alike.

/label px-approved

RickJWagner avatar Mar 21 '24 18:03 RickJWagner

Sorry I missed this, feel free to ping me when you are ready for the docs-approved label.

opayne1 avatar Mar 25 '24 16:03 opayne1

@opayne1 Thank you for the review! I have applied your suggestions.

vojtechszocs avatar Mar 27 '24 17:03 vojtechszocs

/lgtm

rhamilto avatar Mar 27 '24 17:03 rhamilto

Thank you!

/label docs-approved

opayne1 avatar Mar 27 '24 17:03 opayne1

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 27 '24 17:03 openshift-ci[bot]

/retest

rhamilto avatar Mar 27 '24 19:03 rhamilto

/retest

rhamilto avatar Mar 27 '24 23:03 rhamilto

@vojtechszocs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 28 '24 04:03 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202403280418.p0.ge6c6f53.assembly.stream.el8 for distgit openshift-enterprise-console. All builds following this will include this PR.

openshift-bot avatar Mar 28 '24 09:03 openshift-bot