console icon indicating copy to clipboard operation
console copied to clipboard

Published 20 hours ago • verified publisher icon openshift

NO-JIRA: Direct OIDC tech debt

Open stlaz opened this issue 1 year ago • 5 comments

Adds unit tests. Fixes a bug in the AsyncCache where it would never return an error on init.

/assign @jhadvig

stlaz avatar Mar 05 '24 10:03 stlaz

@stlaz: This pull request explicitly references no jira issue.

In response to this:

Adds unit tests. Fixes a bug in the AsyncCache where it would never return an error on init.

/assign @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 05 '24 10:03 openshift-ci-robot

/hold I've found another bug with how the async cache handles contexts

stlaz avatar Mar 14 '24 12:03 stlaz

/hold cancel another asynccache bug fixed in the last commit

stlaz avatar Mar 14 '24 13:03 stlaz

@stlaz: This pull request references CONSOLE-3916 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adds unit tests. Fixes a bug in the AsyncCache where it would never return an error on init.

/assign @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 28 '24 12:03 openshift-ci-robot

/hold for https://github.com/openshift/console/pull/13703

stlaz avatar Mar 28 '24 12:03 stlaz

/hold cancel @jhadvig if I may ask you to retag

stlaz avatar Apr 02 '24 09:04 stlaz

/lgtm /retest

jhadvig avatar Apr 03 '24 11:04 jhadvig

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 03 '24 11:04 openshift-ci[bot]

/retest-required

stlaz avatar Apr 04 '24 07:04 stlaz

/retest-required

stlaz avatar Apr 08 '24 08:04 stlaz

QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @RickJWagner

jhadvig avatar Apr 09 '24 12:04 jhadvig

@yapei here we will need to do just regression testing, no additional TCs are needed, since the change is mainly adding unit tests and refactoring code.

jhadvig avatar Apr 09 '24 12:04 jhadvig

/label px-approved

RickJWagner avatar Apr 09 '24 16:04 RickJWagner

/label docs-approved

opayne1 avatar Apr 09 '24 18:04 opayne1

Normal regression test passed. /label qe-approved

yanpzhan avatar Apr 11 '24 06:04 yanpzhan

@stlaz: This pull request references CONSOLE-3916 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adds unit tests. Fixes a bug in the AsyncCache where it would never return an error on init.

/assign @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot avatar Apr 11 '24 06:04 openshift-bot

/retest-required

Remaining retests: 0 against base HEAD d384948f3a5c0a82e09218e6b3d5ccf14785fa2e and 2 for PR HEAD 17cc56e2a8a6b2b65dcc186d49db31cac63aa5e6 in total

openshift-bot avatar Apr 11 '24 09:04 openshift-bot