console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-28723: Improve Create serverless function error message

Open Lucifergene opened this issue 1 year ago • 11 comments
trafficstars

Fixes: https://issues.redhat.com/browse/OCPBUGS-28723

Analysis / Root cause: The requirement of func.yaml was not clear and had no info about it.

Solution Description: Added a proper reason and link to explore the Func CLI.

Screen shots / Gifs for design review: image

Unit test coverage report: Not changed

Test setup:

  1. Install Serverless operator
  2. Paste a random Git Repo URL in the Create Serverless Function Form.

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari
  • [ ] Edge

Lucifergene avatar Feb 08 '24 07:02 Lucifergene

@Lucifergene: This pull request references Jira Issue OCPBUGS-28723, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-28723

Analysis / Root cause: The requirement of func.yaml was not clear and had no info about it.

Solution Description: Added a proper reason and link to explore the Func CLI.

Screen shots / Gifs for design review: image

Unit test coverage report: Not changed

Test setup:

  1. Install Serverless operator
  2. Paste a random Git Repo URL in the Create Serverless Function Form.

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari
  • [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 08 '24 07:02 openshift-ci-robot

/jira refresh

Lucifergene avatar Feb 08 '24 07:02 Lucifergene

@Lucifergene: This pull request references Jira Issue OCPBUGS-28723, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 08 '24 07:02 openshift-ci-robot

/test frontend

Lucifergene avatar Feb 11 '24 13:02 Lucifergene

/retest

Lucifergene avatar Feb 12 '24 04:02 Lucifergene

/test frontend

Lucifergene avatar Feb 12 '24 07:02 Lucifergene

/retest

Lucifergene avatar Feb 19 '24 08:02 Lucifergene

/retest

Lucifergene avatar Feb 19 '24 14:02 Lucifergene

Tested locally. Working fine.

/lgtm

lokanandaprabhu avatar Feb 22 '24 07:02 lokanandaprabhu

/lgtm

lokanandaprabhu avatar Apr 12 '24 08:04 lokanandaprabhu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, Lucifergene, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 18 '24 11:04 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 240719d4b49838b37f59a9b67d4e26ea29172304 and 2 for PR HEAD b66e57f6b4ff43070e42d6e289a80615f74ad66b in total

openshift-ci-robot avatar Apr 19 '24 04:04 openshift-ci-robot

@Lucifergene: Jira Issue OCPBUGS-28723: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28723 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-28723

Analysis / Root cause: The requirement of func.yaml was not clear and had no info about it.

Solution Description: Added a proper reason and link to explore the Func CLI.

Screen shots / Gifs for design review: image

Unit test coverage report: Not changed

Test setup:

  1. Install Serverless operator
  2. Paste a random Git Repo URL in the Create Serverless Function Form.

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari
  • [ ] Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 19 '24 06:04 openshift-ci-robot

/cherry-pick release-4.15

christoph-jerolimov avatar Apr 19 '24 18:04 christoph-jerolimov

@jerolimov: new pull request created: #13778

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.