console icon indicating copy to clipboard operation
console copied to clipboard

OCPBUGS-28702, CNV-35417: Remove empty annotation from nad

Open metalice opened this issue 1 year ago • 15 comments

In case of empty/lacking annotation - dont add it to nad

metalice avatar Dec 27 '23 09:12 metalice

@metalice: This pull request references CNV-35417 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

In case of empty/lacking annotation - dont add it to nad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Dec 27 '23 09:12 openshift-ci-robot

/lgtm

pcbailey avatar Jan 31 '24 00:01 pcbailey

@metalice: This pull request references Jira Issue OCPBUGS-28702, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references CNV-35417 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

In case of empty/lacking annotation - dont add it to nad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 21 '24 14:02 openshift-ci-robot

@metalice: This pull request references CNV-35417 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

In case of empty/lacking annotation - dont add it to nad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 21 '24 14:02 openshift-ci-robot

/jira refresh

jhadvig avatar Feb 21 '24 14:02 jhadvig

@jhadvig: This pull request references CNV-35417 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 21 '24 14:02 openshift-ci-robot

/label acknowledge-critical-fixes-only

jhadvig avatar Feb 21 '24 14:02 jhadvig

@metalice do we need to backport to 4.15 ?

jhadvig avatar Feb 21 '24 14:02 jhadvig

@jhadvig it's better if we can backport this to 4.15.

gouyang avatar Apr 16 '24 08:04 gouyang

/cherry-pick release-4.15

gouyang avatar May 27 '24 23:05 gouyang

@gouyang: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jhadvig @metalice is there any chance for us to merge this to 4.16?

gouyang avatar May 27 '24 23:05 gouyang

/lgtm

pcbailey avatar Jul 29 '24 11:07 pcbailey

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 29 '24 11:07 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Oct 28 '24 01:10 openshift-bot

/retitle CNV-35417, OCPBUGS-28702: Remove empty annotation from nad

logonoff avatar Nov 20 '24 01:11 logonoff

@metalice: This pull request references CNV-35417 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.16.z" instead.

This pull request references Jira Issue OCPBUGS-28702, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.16.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In case of empty/lacking annotation - dont add it to nad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 20 '24 01:11 openshift-ci-robot

/jira refresh

logonoff avatar Nov 20 '24 01:11 logonoff

@logonoff: This pull request references CNV-35417 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-28702, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @gouyang

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 20 '24 01:11 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD f371d4a9bff27adda50363d7bd00b1fc2351efa3 and 2 for PR HEAD 85ad6c0d8e151531dd327f3db7e4bc9bb1348cb1 in total

openshift-ci-robot avatar Nov 20 '24 03:11 openshift-ci-robot

@metalice: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 20 '24 06:11 openshift-ci[bot]

@metalice: Jira Issue OCPBUGS-28702: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28702 has been moved to the MODIFIED state.

In response to this:

In case of empty/lacking annotation - dont add it to nad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 20 '24 06:11 openshift-ci-robot

@gouyang: #13468 failed to apply on top of branch "release-4.15":

Applying: CNV-35417: Remove empty annotation from nad
Using index info to reconstruct a base tree...
M	frontend/packages/network-attachment-definition-plugin/src/components/network-attachment-definitions/NetworkAttachmentDefinitionsForm.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/network-attachment-definition-plugin/src/components/network-attachment-definitions/NetworkAttachmentDefinitionsForm.tsx
CONFLICT (content): Merge conflict in frontend/packages/network-attachment-definition-plugin/src/components/network-attachment-definitions/NetworkAttachmentDefinitionsForm.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-35417: Remove empty annotation from nad

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411200908.p0.g895a785.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Nov 20 '24 12:11 openshift-bot