console
console copied to clipboard
openshift
OCPBUGS-22853: Keep useActiveNamespace hook in the internal api
This change is to avoid a API breaking change. KubeVirt plugin needed to do following changes in order to get rid of the error.
Since this was introduced in 4.14 we should be probably backporting this issue.
/assign @sg00dwin @vojtechszocs
@jhadvig: This pull request references Jira Issue OCPBUGS-22853, which is invalid:
- expected the bug to target the "4.15.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
This change is to avoid a API breaking change. KubeVirt plugin needed to do following changes in order to get rid of the error.
Since this was introduced in 4.14 we should be probably backporting this issue.
/assign @sg00dwin @vojtechszocs
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jhadvig: This pull request references Jira Issue OCPBUGS-22853, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.15.0) matches configured target version for branch (4.15.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jhadvig Hi, the bug is critical for openshift virtualization, could you take a look at the PR and get it merged soon? Thanks.
@jhadvig @gouyang
The useActiveNamespace hook was promoted from Console internal SDK pkg to Console core SDK pkg as part of #13033.
Consumers of this hook should update their import from
import { useActiveNamespace } from '@openshift-console/dynamic-plugin-sdk-internal';
to
import { useActiveNamespace } from '@openshift-console/dynamic-plugin-sdk';
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
@jhadvig Hi, could you take a look at this again? This is a critical issue for kubevirt-plugin, thanks!
@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.
In response to this:
/cherrypick release-4.16 release-4.15 release-4.14
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, rhamilto
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/packages/console-dynamic-plugin-sdk/OWNERS~~ [jhadvig,rhamilto]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jhadvig: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
I start believing that we should consider about reverting https://github.com/openshift/console/pull/13843 and skipping this one
Closing this one since its no longer needed due to https://github.com/kubevirt-ui/kubevirt-plugin/pull/1489
@jhadvig: This pull request references Jira Issue OCPBUGS-22853. The bug has been updated to no longer refer to the pull request using the external bug tracker.
In response to this:
This change is to avoid a API breaking change. KubeVirt plugin needed to do following changes in order to get rid of the error.
Since this was introduced in 4.14 we should be probably backporting this issue.
/assign @sg00dwin @vojtechszocs
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.