configure-alertmanager-operator icon indicating copy to clipboard operation
configure-alertmanager-operator copied to clipboard

Published 20 hours ago • verified publisher icon openshift

Update module github.com/onsi/ginkgo/v2 to v2.23.4

Open red-hat-konflux[bot] opened this issue 9 months ago • 4 comments

This PR contains the following updates:

Package Type Update Change
github.com/onsi/ginkgo/v2 require minor v2.20.2 -> v2.23.4

[!WARNING] Some dependencies could not be looked up. Check the warning logs for more information.

Release Notes

onsi/ginkgo (github.com/onsi/ginkgo/v2)

v2.23.4

Compare Source

2.23.4

Prior to this release Ginkgo would compute the incorrect number of available CPUs when running with -p in a linux container. Thanks to @​emirot for the fix!

Features
  • Add automaxprocs for using CPUQuota [2b9c428]
Fixes
  • clarify gotchas about -vet flag [1f59d07]
Maintenance

v2.23.3

Compare Source

2.23.3

Fixes
  • allow - as a standalone argument [cfcc1a5]
  • Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context() [feaf292]
  • ignore exit code for symbol test on linux [88e2282]

v2.23.2

Compare Source

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.

v2.23.1

Compare Source

2.23.1

🚨 For users on MacOS 🚨

A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.

Fixes

Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:

  • make it clearer that you need to pass a filename to the various profile flags, not an absolute directory [a0e52ff]
  • emit an error and exit if the ginkgo invocation includes flags after positional arguments [b799d8d]

This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.

v2.23.0

Compare Source

2.23.0

Ginkgo 2.23.0 adds a handful of methods to GinkgoT() to make it compatible with the testing.TB interface in Go 1.24. GinkgoT().Context(), in particular, is a useful shorthand for generating a new context that will clean itself up in a DeferCleanup(). This has subtle behavior differences from the golang implementation but should make sense in a Ginkgo... um... context.

Features
  • bump to go 1.24.0 - support new testing.TB methods and add a test to cover testing.TB regressions [37a511b]
Fixes
  • fix edge case where build -o is pointing at an explicit file, not a directory [7556a86]
  • Fix binary paths when precompiling multiple suites. [4df06c6]
Maintenance

v2.22.2

Compare Source

What's Changed

Full Changelog: https://github.com/onsi/ginkgo/compare/v2.22.1...v2.22.2

v2.22.1

Compare Source

2.22.1

Fixes

Fix CSV encoding

Maintenance
  • ensure *.test files are gitignored so we don't accidentally commit compiled tests again [c88c634]
  • remove golang.org/x/net/context in favour of stdlib context [4df44bf]

v2.22.0

Compare Source

2.22.0

Features
  • Add label to serial nodes [0fcaa08]

This allows serial tests to be filtered using the label-filter

Maintenance

Various doc fixes

v2.21.0

Compare Source

2.21.0

Features
  • add support for GINKGO_TIME_FORMAT [a69eb39]
  • add GINKGO_NO_COLOR to disable colors via environment variables [bcab9c8]
Fixes
  • increase threshold in timeline matcher [e548367]
  • Fix the document by replacing SpecsThatWillBeRun with SpecsThatWillRun [c2c4d3c]
Maintenance
  • bump various dependencies [7e65a00]

Configuration

📅 Schedule: Branch creation - "after 5am on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • [ ] If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

This PR has been generated by MintMaker (powered by Renovate Bot).

red-hat-konflux[bot] avatar Feb 23 '25 16:02 red-hat-konflux[bot]

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 9 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.22.8 -> 1.23.8
github.com/onsi/gomega v1.34.2 -> v1.36.3
github.com/google/go-cmp v0.6.0 -> v0.7.0
github.com/google/pprof v0.0.0-20240827171923-fa2c70bbbfe5 -> v0.0.0-20250403155104-27863c87afa6
golang.org/x/net v0.29.0 -> v0.37.0
golang.org/x/sys v0.25.0 -> v0.32.0
golang.org/x/term v0.24.0 -> v0.30.0
golang.org/x/text v0.18.0 -> v0.23.0
golang.org/x/tools v0.24.0 -> v0.31.0
google.golang.org/protobuf v1.34.2 -> v1.36.5

red-hat-konflux[bot] avatar Feb 23 '25 16:02 red-hat-konflux[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot] Once this PR has been reviewed and has the lgtm label, please assign clcollins for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Feb 23 '25 16:02 openshift-ci[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.82%. Comparing base (ca96941) to head (302c28c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   65.82%   65.82%           
=======================================
  Files           7        7           
  Lines         910      910           
=======================================
  Hits          599      599           
  Misses        288      288           
  Partials       23       23

codecov[bot] avatar Feb 23 '25 16:02 codecov[bot]

@red-hat-konflux[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 0b4224728a4a3e12d5960dc4074529379751cbec link true /test images
ci/prow/coverage 0b4224728a4a3e12d5960dc4074529379751cbec link true /test coverage
ci/prow/validate 0b4224728a4a3e12d5960dc4074529379751cbec link true /test validate
ci/prow/test 0b4224728a4a3e12d5960dc4074529379751cbec link true /test test
ci/prow/e2e-binary-build-success 0b4224728a4a3e12d5960dc4074529379751cbec link true /test e2e-binary-build-success
ci/prow/lint 0b4224728a4a3e12d5960dc4074529379751cbec link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 06 '25 21:04 openshift-ci[bot]

/close # Stale

clcollins avatar Sep 02 '25 22:09 clcollins

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Sep 02 '25 22:09 openshift-merge-robot

/close

clcollins avatar Sep 02 '25 22:09 clcollins

@clcollins: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Sep 02 '25 23:09 openshift-ci[bot]