configuration-anomaly-detection
configuration-anomaly-detection copied to clipboard
openshift
[PoC] Custom interceptor
This is a PoC as part of RDA7: this PR adds a custom interceptor that allows routing all alerts to CAD without starting a new pipeline for each alert. To achieve this, we create a custom interceptor in the form of a small http service that will determine whether or not we handle the alert or escalate it.
TODOs:
- the interceptor must contain the logic for incident -> alert mapping
- deployment of the interceptor needs to be part of CAD deployment
Codecov Report
Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
Project coverage is 37.82%. Comparing base (
24e690d) to head (3327074). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 38.07% 37.82% -0.25%
==========================================
Files 19 19
Lines 1547 1557 +10
==========================================
Hits 589 589
- Misses 919 929 +10
Partials 39 39
| Files | Coverage Δ | |
|---|---|---|
| pkg/metrics/metrics.go | 16.66% <0.00%> (ø) |
|
| pkg/pagerduty/pagerduty.go | 69.96% <0.00%> (-2.57%) |
:arrow_down: |
@typeid: This pull request references OSD-23695 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
This is a PoC as part of RDA7: this PR adds a custom interceptor that allows routing all alerts to CAD without starting a new pipeline for each alert. To achieve this, we create a custom interceptor in the form of a small http service that will determine whether or not we handle the alert or escalate it.
TODOs:
- the interceptor must contain the logic for incident -> alert mapping
- deployment of the interceptor needs to be part of CAD deployment
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@typeid: This pull request references OSD-23695 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
This PR adds a custom interceptor that allows routing all alerts to CAD without starting a new pipeline for each alert. To achieve this, we create a custom interceptor in the form of a small http service that will determine whether or not we handle the alert or escalate it.
This PR does not yet add a deployment, therefore the binary is unused. The deployment will be added in a follow up PR.
https://issues.redhat.com/browse/OSD-23695
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
I added a couple of comments on minor things, apart from that it looks good.
@typeid:
In response to this:
/honk
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: typeid, zmird-r
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [typeid,zmird-r]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@typeid: 
In response to this:
/meow
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest
Ran into a timeout, maybe I need to increase the timeout since we're now linting more things.
@typeid: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.