configuration-anomaly-detection icon indicating copy to clipboard operation
configuration-anomaly-detection copied to clipboard

PoC: k8s client usage for UWM down

Open typeid opened this issue 1 year ago • 8 comments

https://issues.redhat.com/browse/OSD-23312

This PR showcases how CAD could use kube api with an example implementation of the remediation to https://issues.redhat.com/browse/OCPBUGS-33863.

The implementation is hidden behind a CAD_EXPERIMENTAL_ENABLED flag that we will enable on staging after enabling kube-api access in https://issues.redhat.com/browse/OSD-23311.

typeid avatar May 17 '24 12:05 typeid

/hold this is an untested draft.

typeid avatar May 17 '24 12:05 typeid

Codecov Report

Attention: Patch coverage is 18.51852% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 37.85%. Comparing base (61b1526) to head (b405fa7). Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   38.93%   37.85%   -1.08%     
==========================================
  Files          17       19       +2     
  Lines        1500     1556      +56     
==========================================
+ Hits          584      589       +5     
- Misses        877      928      +51     
  Partials       39       39              
Files Coverage Δ
...rrorbudgetburn/clustermonitoringerrorbudgetburn.go 18.51% <18.51%> (ø)

... and 2 files with indirect coverage changes

codecov-commenter avatar May 17 '24 12:05 codecov-commenter

I was able to test this already thanks to backplane-cli using my ocm-token.

typeid avatar May 17 '24 14:05 typeid

Waiting for this backplane api change, as we need to be able to pass our ocm connection for the backplane kube-api auth

typeid avatar May 17 '24 14:05 typeid

/unhold

backplane-cli dependency PR merged. We're good to move ahead with this PR.

typeid avatar May 21 '24 06:05 typeid

/hold

typeid avatar May 27 '24 09:05 typeid

/unhold

Ready to merge! :)

typeid avatar May 28 '24 06:05 typeid

Looks good! /lgtm

zmird-r avatar May 28 '24 08:05 zmird-r

/lgtm

zmird-r avatar May 28 '24 08:05 zmird-r

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: typeid, zmird-r

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 28 '24 08:05 openshift-ci[bot]

@typeid: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 28 '24 08:05 openshift-ci[bot]