cluster-logging-operator icon indicating copy to clipboard operation
cluster-logging-operator copied to clipboard

Update api_observability_v1.adoc

Open faldanarh opened this issue 1 year ago • 4 comments

Description

Have fixed the content presentation int the Cloudwatch section. The table was broken due to the "||" characters. Inserted the backslash to prevent it.

/cc /assign

Links

None

faldanarh avatar Oct 28 '24 03:10 faldanarh

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: faldanarh Once this PR has been reviewed and has the lgtm label, please assign alanconway for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 28 '24 03:10 openshift-ci[bot]

@faldanarh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 64689b612d971ddbcc133da6b9daaabacab801b2 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 28 '24 04:10 openshift-ci[bot]

@faldanarh we are more then happy to accept improvements to any bits of this code base. Note this document is autogenerated and any changes need to be sourced in the api go code. You must:

  • edit the code
  • run make generate bundle docs/reference/operator/api_observability_v1.adoc

This should result in three files being changed

/hold

jcantrill avatar Oct 28 '24 12:10 jcantrill

Have fixed the content presentation int the Cloudwatch section. The table was broken due to the "||" characters. Inserted the backslash to prevent it.

@jcantrill I have done what you requested and created a new PR #2851

faldanarh avatar Oct 29 '24 05:10 faldanarh

Closing this in favour of #2851

alanconway avatar Oct 31 '24 14:10 alanconway

/close

alanconway avatar Oct 31 '24 14:10 alanconway

@alanconway: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Oct 31 '24 14:10 openshift-ci[bot]