LOG-6128: Fix console plugin api version

[jgbernalp]

Description

From OCP v4.17+, the ConsolePlugin v1alpha1 was deprecated in favor of ConsolePlugin v1. This causes the logging plugin to fail during reconciliation as the new version of the spec needs for 4.17+. This PR adds support for ConsolePlugin v1 when the operator is running on clusters with v4.17+

This is targeted directly to the 5.9 branch as 6.0 (master) has removed the console plugin

/cc @jcantrill
/assign @alanconway

Links

• JIRA: LOG-6128

[openshift-ci-robot]

@jgbernalp: This pull request references LOG-6128 which is a valid jira issue.

In response to this:

Description

From OCP v4.17+, the ConsolePlugin v1alpha1 was deprecated in favor of ConsolePlugin v1. This causes the logging plugin to fail during reconciliation as the new version of the spec needs for 4.17+. This PR adds support for ConsolePlugin v1 when the operator is running on clusters with v4.17+

This is targeted directly to the 5.9 branch as 6.0 (master) has removed the console plugin

/cc @jcantrill
/assign @alanconway

Links

• JIRA: LOG-6128

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [jcantrill]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci[bot]]

New changes are detected. LGTM label has been removed.

[openshift-ci[bot]]

@jgbernalp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	6abb572f1c12e60b7e76ba0474bc7be4c7dcef2f	link	true	/test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[anpingli]

Must we fix it?
For 5.9: CLO 5.9 don't support v4.17.
For 5.8: CLO 5.8 and EO 5.8 are extended to 4.17, while Loki-operator 5.8 doesn't support OCP 4.17.

[jgbernalp]

/hold

[anpingli]

The consoleplugin works well on Openshift 4.17. But on openshift 4.14, the logging-view-plugin can not be replaced with LoggingUI Plugin.

CLO report error below.

{"_ts":"2024-10-22T14:30:39.530899307Z","_level":"0","_component":"cluster-logging-operator","_message":"reconciled console","plugin":"console.openshift.io/v1alpha1/consoleplugins/logging-view-plugin"}
{"_ts":"2024-10-22T14:30:39.747834374Z","_level":"0","_component":"cluster-logging-operator","_message":"reconciling console","_error":{"msg":"consoleplugins.console.openshift.io \"logging-view-plugin\" already exists"},"plugin":"console.openshift.io/v1alpha1/consoleplugins/logging-view-plugin"}
{"_ts":"2024-10-22T14:30:39.796148281Z","_level":"0","_component":"cluster-logging-operator","_message":"Error reconciling clusterlogging instance","_error":{"msg":"unable to create or update visualization for \"instance\": consoleplugins.console.openshift.io \"logging-view-plugin\" already exists"}}
{"_ts":"2024-10-22T14:30:39.817392069Z","_level":"0","_component":"cluster-logging-operator","_message":"Reconciler error","ClusterLogging":{"name":"instance","namespace":"openshift-logging"},"_error":{"msg":"unable to create or update visualization for \"instance\": consoleplugins.console.openshift.io \"logging-view-plugin\" already exists"},"controller":"clusterlogging","controllerGroup":"logging.openshift.io","controllerKind":"ClusterLogging","name":"instance","namespace":"openshift-logging","reconcileID":"369bb700-a119-4829-a50c-c06de614439b"}

logging-view-plugin pod are created and deleted frequently.

$ oc get pods
NAME                                               READY   STATUS        RESTARTS   AGE
cluster-logging-operator-65dc977d8d-kft2k          1/1     Running       0          101m
collector-gh7n5                                    1/1     Running       0          101m
collector-gjsn2                                    1/1     Running       0          101m
collector-hz4ct                                    1/1     Running       0          101m
collector-ngpck                                    1/1     Running       0          101m
collector-zpp5q                                    1/1     Running       0          101m
collector-zpwt2                                    1/1     Running       0          101m
logging-view-plugin-84c48f4799-26k8c               0/1     Terminating   0          4s
logging-view-plugin-84c48f4799-277q2               0/1     Terminating   0          35s
logging-view-plugin-84c48f4799-2d74f               0/1     Terminating   0          55s
logging-view-plugin-84c48f4799-2j55f               0/1     Terminating   0          97s
logging-view-plugin-84c48f4799-2n6hb               0/1     Terminating   0          26s
logging-view-plugin-84c48f4799-2vhnb               0/1     Terminating   0          78s
logging-view-plugin-84c48f4799-44m2c               0/1     Terminating   0          17s
logging-view-plugin-84c48f4799-48p5z               0/1     Terminating   0          86s