cluster-logging-operator icon indicating copy to clipboard operation
cluster-logging-operator copied to clipboard

LOG-6084: Refactor internal model

Open jcantrill opened this issue 1 year ago • 16 comments

Description

This PR:

  • replaces ViaQ with an internal model (made up of Viaq bits)
  • Formats entries to ViaQ as postfilter to allow fields to be consinstently available for filtering and output needs
  • prepares for 6.1 to write to LokiStack OTLP

Links

  • https://issues.redhat.com/browse/LOG-6084

jcantrill avatar Sep 04 '24 19:09 jcantrill

/hold

jcantrill avatar Sep 04 '24 19:09 jcantrill

/retest

jcantrill avatar Sep 04 '24 20:09 jcantrill

/retest

jcantrill avatar Sep 05 '24 13:09 jcantrill

/retest

jcantrill avatar Sep 05 '24 15:09 jcantrill

/retest

jcantrill avatar Sep 05 '24 16:09 jcantrill

/retest

jcantrill avatar Sep 05 '24 20:09 jcantrill

/test functional-target

jcantrill avatar Sep 10 '24 17:09 jcantrill

/test functional-target

jcantrill avatar Sep 10 '24 18:09 jcantrill

/test functional-target

jcantrill avatar Sep 10 '24 18:09 jcantrill

/test functional-target

jcantrill avatar Sep 10 '24 19:09 jcantrill

@jcantrill: This pull request references LOG-6084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR:

  • replaces ViaQ with an internal model (made up of Viaq bits)
  • Formats entries to ViaQ as postfilter to allow fields to be consinstently available for filtering and output needs
  • prepares for 6.1 to write to LokiStack OTLP

Links

  • https://issues.redhat.com/browse/LOG-6084

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 23 '24 19:09 openshift-ci-robot

/retest

jcantrill avatar Sep 24 '24 18:09 jcantrill

/retest

jcantrill avatar Sep 25 '24 18:09 jcantrill

/retest

jcantrill avatar Sep 26 '24 19:09 jcantrill

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Feb 04 '25 01:02 openshift-bot

/test e2e-target

jcantrill avatar Feb 05 '25 14:02 jcantrill

/test functional-target

jcantrill avatar Feb 14 '25 14:02 jcantrill

/test e2e-target

jcantrill avatar Feb 14 '25 14:02 jcantrill

/test functional-target

jcantrill avatar Feb 20 '25 13:02 jcantrill

/test functional-target

jcantrill avatar Feb 20 '25 16:02 jcantrill

@jcantrill: This pull request references LOG-6084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR:

  • replaces ViaQ with an internal model (made up of Viaq bits)
  • Formats entries to ViaQ as postfilter to allow fields to be consinstently available for filtering and output needs

Links

  • https://issues.redhat.com/browse/LOG-6084

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 20 '25 18:02 openshift-ci-robot

Verified forward to LokiStack, Cloudwatch and syslog with this PR but QE will do a full regression on this refactor change.

kabirbhartiRH avatar Mar 18 '25 18:03 kabirbhartiRH

/hold cancel

jcantrill avatar Mar 20 '25 15:03 jcantrill

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [alanconway,jcantrill]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 20 '25 18:03 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 117d88824baa80feab81b6eb039455f7dcb17f3d and 2 for PR HEAD bc28f570b8633a73e3a770d817ad05ae92a9bfda in total

openshift-ci-robot avatar Mar 20 '25 18:03 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 1ceec2fe7f21ae529332440897e4178943b6adcc and 1 for PR HEAD bc28f570b8633a73e3a770d817ad05ae92a9bfda in total

openshift-ci-robot avatar Mar 20 '25 21:03 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD 1ceec2fe7f21ae529332440897e4178943b6adcc and 2 for PR HEAD bc28f570b8633a73e3a770d817ad05ae92a9bfda in total

openshift-ci-robot avatar Mar 21 '25 00:03 openshift-ci-robot

/test unit

jcantrill avatar Mar 21 '25 12:03 jcantrill

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 21 '25 13:03 openshift-ci[bot]