cluster-logging-operator
cluster-logging-operator copied to clipboard
openshift
LOG-2866: Add k8s recommended labels
Description
Added kubernetes recommended labels to resources created by Cluster Logging Operator.
/cc /assign
/cherry-pick
Links
- Depending on PR(s):
- Bugzilla:
- Github issue:
- JIRA:
- Enhancement proposal:
/approve cancel /hold
@vimalk78: GitHub didn't allow me to request PR reviews from the following users: vimalk78.
Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
Description
Added kubernetes recommended labels to resources created by Cluster Logging Operator.
/cc /assign
/cherry-pick
Links
- Depending on PR(s):
- Bugzilla:
- Github issue:
- JIRA:
- Enhancement proposal:
/approve cancel /hold
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vimalk78
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [vimalk78]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 2 against base HEAD 7b576316155449d364796e2b850c0fb9bcd1bd3f and 8 for PR HEAD a9ec0df3e3deb05881946b6539baf92aa682233f in total
/retest-required
Remaining retests: 1 against base HEAD 7b576316155449d364796e2b850c0fb9bcd1bd3f and 7 for PR HEAD a9ec0df3e3deb05881946b6539baf92aa682233f in total
/retest-required
Remaining retests: 0 against base HEAD 7b576316155449d364796e2b850c0fb9bcd1bd3f and 6 for PR HEAD a9ec0df3e3deb05881946b6539baf92aa682233f in total
/retest-required
Remaining retests: 2 against base HEAD 7f58d37d11bfe887ab240afeadb2d1741e97445d and 5 for PR HEAD a9ec0df3e3deb05881946b6539baf92aa682233f in total
/retest-required
Remaining retests: 1 against base HEAD 7f58d37d11bfe887ab240afeadb2d1741e97445d and 4 for PR HEAD a9ec0df3e3deb05881946b6539baf92aa682233f in total
/retest-required
Remaining retests: 0 against base HEAD 7f58d37d11bfe887ab240afeadb2d1741e97445d and 3 for PR HEAD a9ec0df3e3deb05881946b6539baf92aa682233f in total
@xperimental i separated labelSelectors and labels , but this test case fails
TestNewDaemonsetSetsAllLabelsToBeTheSame https://github.com/openshift/cluster-logging-operator/blob/a9ec0df3e3deb05881946b6539baf92aa682233f/internal/factory/daemonset_test.go#L25
@vimalk78 The test was probably written with "selector labelset and labels will be the same" in mind and this needs updating now.
@vimalk78: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/ci-index-cluster-logging-operator-bundle | a9ec0df3e3deb05881946b6539baf92aa682233f | link | true | /test ci-index-cluster-logging-operator-bundle |
| ci/prow/e2e | 244e04610fc1f542af55ec1f57a4a808d70c0456 | link | true | /test e2e |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
closing PR. Purpose of PR was adding labels (preferably uniform) which can be configured in vector to filter out log collection of logging components, so that it doesnt go into a positive feedback, not to comply with kubernetes recommendations. Will open a separate PR for adding these labels, or work with existing labels.