CFE-1130: AWS DAY2 TAG Reconcile

[anirudhAgniRedhat]

This piece of code adds the support to append the extra tags provided by the user for DAY2 Implementation. The background for this requirement can be found in https://issues.redhat.com/browse/CFE-1122

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 42.30769% with 45 lines in your changes missing coverage. Please review.

Project coverage is 47.15%. Comparing base (2c25ae6) to head (3ab951a). Report is 12 commits behind head on master.

Files with missing lines	Patch %	Lines
...redentialsrequest/credentialsrequest_controller.go	13.72%	44 Missing :warning:
pkg/aws/actuator/actuator.go	96.29%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
- Coverage   47.28%   47.15%   -0.14%     
==========================================
  Files          96       96              
  Lines       11712    11789      +77     
==========================================
+ Hits         5538     5559      +21     
- Misses       5563     5617      +54     
- Partials      611      613       +2     

Flag	Coverage Δ
	47.15% <42.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/assets/bootstrap/bindata.go	23.85% <ø> (ø)
pkg/aws/actuator/actuator.go	64.65% <96.29%> (+0.59%)	:arrow_up:
...redentialsrequest/credentialsrequest_controller.go	44.23% <13.72%> (-2.35%)	:arrow_down:

... and 2 files with indirect coverage changes

[openshift-ci-robot]

@anirudhAgniRedhat: This pull request references CFE-1130 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This piece of code adds the support to append the extra tags provided by the user for DAY2 Implementation. The background for this requirement can be found in https://issues.redhat.com/browse/CFE-1122

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[anirudhAgniRedhat]

/retest

[jstuever]

/assign

[anirudhAgniRedhat]

/retest

[anirudhAgniRedhat]

Hey @jstuever Can you please provide me the review for the changes

Thanks!

[anirudhAgniRedhat]

/retest

[anirudhAgniRedhat]

I apologize for the delay; the reordering and reformatting of the yaml files made this unnecessarily difficult to review. I had a few questions, nitpicks, notes, and requested changes.

I Agree!! but updating the API vendor was necessary here!! Thanks for the initial reviews, I have added the requested changes!!

[jstuever]

/test e2e-hypershift

[jstuever]

/hold Ensure e2e-hypershift passes due to adding a new watch() and prior hypershift issues with memory usage.

[jstuever]

/lgtm /approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anirudhAgniRedhat, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [jstuever]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[jstuever]

/test e2e-hypershift

[anirudhAgniRedhat]

/retest Error message states

  * could not run steps: step e2e-hypershift failed: "e2e-hypershift" pre steps failed: could not determine image pull spec for image hypershift-operator on step hypershift-install 
INFO[2024-09-30T18:13:17Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:utilizing_lease:executing_test:executing_multi_stage_test' 

Need to check a bit on this!! previously these were passing for me before the latest commit which I don't feel should be a breaking change!

[anirudhAgniRedhat]

/retest

[openshift-ci[bot]]

@anirudhAgniRedhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jstuever]

/hold cancel

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.18.0-202410022110.p0.ge133084.assembly.stream.el9. All builds following this will include this PR.