cloud-credential-operator
cloud-credential-operator copied to clipboard
CCO-571: Add GCP pod identity webhook
This change adds the GCP Workload Identity Webhook when the cluster platform is GCP. The cloud-credential-operator ensures the deployment, pods, and mutating webhook exists.
@jstuever: This pull request references CCO-571 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
This change adds the GCP Workload Identity Webhook when the cluster platform is GCP. The cloud-credential-operator ensures the deployment, pods, and mutating webhook exists.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Codecov Report
Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.
Project coverage is 48.52%. Comparing base (
d668c18) to head (e84e263). Report is 12 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #758 +/- ##
==========================================
+ Coverage 47.24% 48.52% +1.28%
==========================================
Files 96 97 +1
Lines 11725 12273 +548
==========================================
+ Hits 5539 5956 +417
- Misses 5573 5689 +116
- Partials 613 628 +15
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...rator/podidentity/podidentitywebhook_controller.go | 27.27% <0.00%> (-0.32%) |
:arrow_down: |
| pkg/operator/podidentity/gcppodidentitywebhook.go | 0.00% <0.00%> (ø) |
|
| pkg/assets/v410_00_assets/bindata.go | 42.71% <0.00%> (-4.25%) |
:arrow_down: |
/hold for gcp webhook image to land in release payloads
/hold cancel /assign @dlom
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dlom, jstuever
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [dlom,jstuever]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jstuever: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.18.0-202410220012.p0.g2a838af.assembly.stream.el9. All builds following this will include this PR.