cloud-credential-operator icon indicating copy to clipboard operation
cloud-credential-operator copied to clipboard

SPLAT-1718: Remove alibaba

Open jcpowermac opened this issue 1 year ago • 8 comments

jcpowermac avatar Jul 26 '24 19:07 jcpowermac

will rewrite the commit history after all tests pass

jcpowermac avatar Jul 26 '24 19:07 jcpowermac

/hold

jcpowermac avatar Jul 26 '24 19:07 jcpowermac

@jcpowermac: This pull request references SPLAT-1718 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 26 '24 19:07 openshift-ci-robot

/retest

jcpowermac avatar Jul 27 '24 14:07 jcpowermac

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.16%. Comparing base (a7f311b) to head (1b38598). Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   46.76%   48.16%   +1.39%     
==========================================
  Files         102       96       -6     
  Lines       12197    11909     -288     
==========================================
+ Hits         5704     5736      +32     
+ Misses       5860     5548     -312     
+ Partials      633      625       -8     
Files Coverage Δ
cmd/ccoctl/main.go 0.00% <ø> (ø)
pkg/apis/cloudcredential/v1/register.go 87.50% <ø> (-0.74%) :arrow_down:

... and 1 file with indirect coverage changes

codecov[bot] avatar Jul 27 '24 16:07 codecov[bot]

/cc

jstuever avatar Jul 31 '24 17:07 jstuever

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 31 '24 17:07 openshift-ci[bot]

/hold cancel

jcpowermac avatar Aug 05 '24 19:08 jcpowermac

/retest-required

Remaining retests: 0 against base HEAD 5d9a5c8f36ba517e94eef1640e05d6980831ac30 and 2 for PR HEAD 1b3859833d21e23ee2d05c25e35141febc93a766 in total

openshift-ci-robot avatar Aug 05 '24 21:08 openshift-ci-robot

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 05 '24 23:08 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.17.0-202408060344.p0.g2c25ae6.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Aug 06 '24 04:08 openshift-bot