cloud-credential-operator
cloud-credential-operator copied to clipboard
SPLAT-1718: Remove alibaba
will rewrite the commit history after all tests pass
/hold
@jcpowermac: This pull request references SPLAT-1718 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 48.16%. Comparing base (
a7f311b) to head (1b38598). Report is 2 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
+ Coverage 46.76% 48.16% +1.39%
==========================================
Files 102 96 -6
Lines 12197 11909 -288
==========================================
+ Hits 5704 5736 +32
+ Misses 5860 5548 -312
+ Partials 633 625 -8
| Files | Coverage Δ | |
|---|---|---|
| cmd/ccoctl/main.go | 0.00% <ø> (ø) |
|
| pkg/apis/cloudcredential/v1/register.go | 87.50% <ø> (-0.74%) |
:arrow_down: |
/cc
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jcpowermac, jstuever
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jstuever]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold cancel
/retest-required
Remaining retests: 0 against base HEAD 5d9a5c8f36ba517e94eef1640e05d6980831ac30 and 2 for PR HEAD 1b3859833d21e23ee2d05c25e35141febc93a766 in total
@jcpowermac: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.17.0-202408060344.p0.g2c25ae6.assembly.stream.el9. All builds following this will include this PR.