cloud-credential-operator icon indicating copy to clipboard operation
cloud-credential-operator copied to clipboard

[WIP] [release-4.15] OCPBUGS-37461: Set required-scc for openshift workloads

Open kramaranya opened this issue 1 year ago • 9 comments
trafficstars

OCPBUGS-37461

Cherry-pick of #681

kramaranya avatar Jul 23 '24 13:07 kramaranya

@kramaranya: This pull request references Jira Issue OCPBUGS-37461, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-37461

Cherry-pick of #681

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 23 '24 13:07 openshift-ci-robot

/jira refresh

kramaranya avatar Jul 23 '24 13:07 kramaranya

@kramaranya: This pull request references Jira Issue OCPBUGS-37461, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-35007 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-35007 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 23 '24 13:07 openshift-ci-robot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.34%. Comparing base (f8455ca) to head (c8a1f8c). Report is 8 commits behind head on release-4.15.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-4.15     #736      +/-   ##
================================================
+ Coverage         48.33%   48.34%   +0.01%     
================================================
  Files                96       96              
  Lines             11798    11813      +15     
================================================
+ Hits               5702     5711       +9     
- Misses             5462     5466       +4     
- Partials            634      636       +2     
Files Coverage Δ
pkg/assets/v410_00_assets/bindata.go 46.96% <ø> (ø)

... and 1 file with indirect coverage changes

codecov[bot] avatar Jul 23 '24 13:07 codecov[bot]

/retest-required

kramaranya avatar Jul 24 '24 07:07 kramaranya

/retest-required

kramaranya avatar Jul 26 '24 10:07 kramaranya

/retest

jstuever avatar Jul 31 '24 17:07 jstuever

/retest

huangmingxia avatar Aug 08 '24 02:08 huangmingxia

/jira refresh

huangmingxia avatar Aug 08 '24 02:08 huangmingxia

@huangmingxia: This pull request references Jira Issue OCPBUGS-37461, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-35007 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-35007 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact: /cc @huangmingxia

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 08 '24 02:08 openshift-ci-robot

/lgtm /approve /label backport-risk-assessed

jstuever avatar Aug 08 '24 22:08 jstuever

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, kramaranya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 08 '24 22:08 openshift-ci[bot]

/override ci/prow/security This is being addressed in another existing Jira big.

jstuever avatar Aug 08 '24 22:08 jstuever

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to this:

/override ci/prow/security This is being addressed in another existing Jira big.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 08 '24 22:08 openshift-ci[bot]

/label cherry-pick-approved

Verified pass with image registry.build05.ci.openshift.org/ci-ln-hxxlz2b/release:latest on 4.15 with below cluster type.

  • AWS
  • AWS STS
  • Azure
  • Entra Workload ID
  • GCP
  • GCP workload ID

huangmingxia avatar Aug 09 '24 13:08 huangmingxia

@kramaranya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 09 '24 15:08 openshift-ci[bot]

@kramaranya: Jira Issue OCPBUGS-37461: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37461 has been moved to the MODIFIED state.

In response to this:

OCPBUGS-37461

Cherry-pick of #681

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 09 '24 15:08 openshift-ci-robot

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.15.0-202408091808.p0.g05c0310.assembly.stream.el8. All builds following this will include this PR.

openshift-bot avatar Aug 09 '24 18:08 openshift-bot

Fix included in accepted release 4.15.0-0.nightly-2024-08-10-090823

openshift-merge-robot avatar Aug 10 '24 16:08 openshift-merge-robot