cincinnati icon indicating copy to clipboard operation
cincinnati copied to clipboard

Bump reqwest from 0.11 to 0.12

Open hongkailiu opened this issue 7 months ago • 3 comments
trafficstars

We have to bump pgp which blocks zeroize which blocks reqwest.

This PR is expected to unblock https://github.com/openshift/cincinnati-graph-data/pull/6016.

/hold

hongkailiu avatar Mar 25 '25 14:03 hongkailiu

This is not cool:

error: rustc 1.79.0 is not supported by the following packages:
  [email protected] requires rustc 1.81

We cannot bump to rustc 1.81 yet in ubi9:

$ podman run -it --arch amd64 --entrypoint='["bash"]' --rm registry.access.redhat.com/ubi9/ubi:latest

[root@afcf192172fb /]# dnf info rust -q
Available Packages
Name         : rust
Version      : 1.79.0
Release      : 3.el9_5
Architecture : x86_64
Size         : 25 M
Source       : rust-1.79.0-3.el9_5.src.rpm
Repository   : ubi-9-appstream-rpms
Summary      : The Rust Programming Language
URL          : https://www.rust-lang.org
License      : (Apache-2.0 OR MIT) AND (Artistic-2.0 AND BSD-3-Clause AND ISC AND MIT AND MPL-2.0 AND
             : Unicode-DFS-2016)
Description  : Rust is a systems programming language that runs blazingly fast, prevents
             : segfaults, and guarantees thread safety.
             :
             : This package includes the Rust compiler and documentation generator.

I tried to downgrade pgp to v0.8.0 (the next to the current v0.7.2) which requires still base64ct v1.7.3.

cargo tree --workspace --target all --all-features --invert base64ct
base64ct v1.7.3
├── pem-rfc7468 v0.3.1
│   └── der v0.5.1
│       ├── pkcs1 v0.3.3
│       │   └── rsa v0.6.1
│       │       └── pgp v0.8.0
│       │           └── cincinnati v0.1.0 (/Users/hongkliu/repo/openshift/cincinnati/cincinnati)
│       │               ├── e2e v0.1.0 (/Users/hongkliu/repo/openshift/cincinnati/e2e)
│       │               ├── graph-builder v0.1.0 (/Users/hongkliu/repo/openshift/cincinnati/graph-builder)
│       │               ├── metadata-helper v0.1.0 (/Users/hongkliu/repo/openshift/cincinnati/metadata-helper)
│       │               └── policy-engine v0.1.0 (/Users/hongkliu/repo/openshift/cincinnati/policy-engine)
│       ├── pkcs8 v0.8.0
│       │   ├── pkcs1 v0.3.3 (*)
│       │   └── rsa v0.6.1 (*)
│       └── spki v0.5.4
│           └── pkcs8 v0.8.0 (*)
└── spki v0.5.4 (*)

hongkailiu avatar Mar 25 '25 19:03 hongkailiu

/retest

hongkailiu avatar May 16 '25 11:05 hongkailiu

https://github.com/openshift/release/pull/65036 is merge

/retest

expecting green ~rehearsals~ CI.

hongkailiu avatar May 16 '25 19:05 hongkailiu

/retest

hongkailiu avatar May 16 '25 20:05 hongkailiu

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rustfmt-1.70.0 4c7aae63b686738e2be679f88589f4cddf31d91f link true /test rustfmt-1.70.0
ci/prow/rustfmt-1.64.0 4c7aae63b686738e2be679f88589f4cddf31d91f link true /test rustfmt-1.64.0
ci/prow/customrust-images 4c7aae63b686738e2be679f88589f4cddf31d91f link true /test customrust-images
ci/prow/customrust-e2e 4c7aae63b686738e2be679f88589f4cddf31d91f link true /test customrust-e2e
ci/prow/customrust-cargo-test 4c7aae63b686738e2be679f88589f4cddf31d91f link true /test customrust-cargo-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 16 '25 20:05 openshift-ci[bot]

/hold cancel

hongkailiu avatar May 23 '25 03:05 hongkailiu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, PratikMahajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 27 '25 15:05 openshift-ci[bot]