ci-tools icon indicating copy to clipboard operation
ci-tools copied to clipboard

ci-images-mirror: set version.Name

Open hongkailiu opened this issue 1 year ago • 3 comments

We do this for logging. It used to work (at least for the logs uploaded to CloudWatch) without it but not any more.

Tested the PR locally, it does the job:

{"component":"ci-images-mirror","file":"/Users/hongkliu/repo/openshift/ci-tools/cmd/ci-images-mirror/main.go:322","func":"main.main","level":"info","msg":"Process ended gracefully","severity":"info","time":"2024-07-31T10:14:13-04:00"}

/cc @openshift/test-platform

hongkailiu avatar Jul 31 '24 14:07 hongkailiu

/test e2e

hongkailiu avatar Jul 31 '24 14:07 hongkailiu

/lgtm

danilo-gemoli avatar Aug 01 '24 07:08 danilo-gemoli

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [danilo-gemoli,hongkailiu]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 01 '24 07:08 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 1420774f51896ba02c21ce2c6dab35f39fa8db89 and 2 for PR HEAD d5374d8f3eb9c41b47ba15f66875258ee39effde in total

openshift-ci-robot avatar Aug 01 '24 07:08 openshift-ci-robot

@hongkailiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security d5374d8f3eb9c41b47ba15f66875258ee39effde link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 01 '24 08:08 openshift-ci[bot]

/override ci/prow/e2e

hongkailiu avatar Aug 01 '24 14:08 hongkailiu

@hongkailiu: Overrode contexts on behalf of hongkailiu: ci/prow/e2e

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 01 '24 14:08 openshift-ci[bot]