ci-chat-bot icon indicating copy to clipboard operation
ci-chat-bot copied to clipboard

Strip whitespace from location tokens

Open stephenfin opened this issue 1 year ago • 2 comments

Currently, the following invocation will fail due to the space after the comma in the CSV list:

build 4.18, openshift-release/csi-operator#275

Start stripping whitespace and allow this to succeed.

stephenfin avatar Sep 24 '24 11:09 stephenfin

/retest

bradmwilliams avatar Sep 25 '24 11:09 bradmwilliams

@stephenfin It looks like you're going to need to run a make update-gofmt on your PR and add the changes to get this PR to merge.

bradmwilliams avatar Sep 25 '24 11:09 bradmwilliams

/retest-required

Remaining retests: 0 against base HEAD 50097f2d4417172742feaa4756f0ad26674bb2fa and 2 for PR HEAD 9e6b01dc82e2d2eb61a188efafab1096119dbdb2 in total

openshift-ci-robot avatar Sep 25 '24 12:09 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 25 '24 12:09 openshift-ci[bot]

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security ffab12a7643a90ca567684722428d56e2c03004b link false /test security
ci/prow/govulncheck ffab12a7643a90ca567684722428d56e2c03004b link false /test govulncheck

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 25 '24 12:09 openshift-ci[bot]

@stephenfin It looks like you're going to need to run a make update-gofmt on your PR and add the changes to get this PR to merge.

Thanks. Too used to Python's flake8, which insists on two spaces before comments :sweat_smile:

stephenfin avatar Sep 25 '24 13:09 stephenfin