Return an error when calling AssumeRole

[anispate]

trafficstars

As part of OSD-14258 ticket where Certman silently fails when calling AssumeRole for sts clusters so, we made sure that it returns an error when calling AssumeRole

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 48.49%. Comparing base (cb8d7a4) to head (ab0125f).

Files	Patch %	Lines
pkg/clients/aws/route53.go	0.00%	10 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   48.63%   48.49%   -0.15%     
==========================================
  Files          28       28              
  Lines        2052     2058       +6     
==========================================
  Hits          998      998              
- Misses        949      955       +6     
  Partials      105      105              

Files	Coverage Δ
pkg/clients/aws/route53.go	39.84% <0.00%> (-0.64%)	:arrow_down:

[tnierman]

/lgtm

[anispate]

/hold

[anispate]

Added hold status so, we don't want to push anything on Friday and also, we wanted to test https://github.com/openshift/certman-operator/pull/283 PR as well for the weekend.

[anispate]

/remove-hold

[anispate]

/retest

[openshift-ci[bot]]

@anispate: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[anispate]

/hold cancel

[iamkirkbater]

/lgtm

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anispate, iamkirkbater, tnierman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [iamkirkbater]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment