boilerplate icon indicating copy to clipboard operation
boilerplate copied to clipboard

SDE-4270 Switch OSDe2e to use OCM Client Credentials

Open MrSantamaria opened this issue 9 months ago • 3 comments
trafficstars

https://issues.redhat.com/browse/SDE-4270

Follow up to: https://github.com/openshift/osde2e/pull/2822/files

This change adds the OCM Client Credentials that OSDe2e will start using once offline tokens are deprecated.

MrSantamaria avatar Feb 04 '25 03:02 MrSantamaria

@MrSantamaria: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Feb 04 '25 04:02 openshift-ci[bot]

hey @MrSantamaria just confirming, is this PR good to go?

joshbranham avatar Apr 24 '25 19:04 joshbranham

/lgtm

we should be passing these 2 vars to Osde2e pod env

ritmun avatar Jun 12 '25 17:06 ritmun

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrSantamaria, ritmun Once this PR has been reviewed and has the lgtm label, please assign dakotalongrh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 12 '25 17:06 openshift-ci[bot]

can be closed - continued in https://github.com/openshift/boilerplate/pull/555

ritmun avatar Jun 12 '25 18:06 ritmun