api icon indicating copy to clipboard operation
api copied to clipboard

Published 20 hours ago • verified publisher icon openshift

(Work in Progress) MCO-1518: Promote MCN to GA

Open isabella-janssen opened this issue 8 months ago • 4 comments

What I did:

  • Copies over the v1alpha1 MCN api into the v1 folder.
  • Removes the unused Spec.PinnedImageSets field.
  • Removes comments suggesting future changes and updates compatibility level.

isabella-janssen avatar Mar 31 '25 19:03 isabella-janssen

@isabella-janssen: This pull request references MCO-1518 which is a valid jira issue.

In response to this:

What I did:

  • Copies over the v1alpha1 MCN api into the v1 folder.
  • Removes the unused Spec.PinnedImageSets field.
  • Removes comments suggesting future changes and updates compatibility level.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 31 '25 19:03 openshift-ci-robot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Mar 31 '25 19:03 openshift-ci[bot]

Hello @isabella-janssen! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Mar 31 '25 19:03 openshift-ci[bot]

/test all

isabella-janssen avatar Mar 31 '25 20:03 isabella-janssen

@isabella-janssen: This pull request references MCO-1518 which is a valid jira issue.

In response to this:

Included work:

  • Copies over the v1alpha1 MCN api into the v1 folder.
  • Removes the unused Spec.PinnedImageSets field.
  • Removes comments suggesting future changes and updates compatibility level.

References:

  • (WIP) Updated enhancement: https://github.com/openshift/enhancements/pull/1765
  • MCN origin tests: https://github.com/openshift/origin/pull/29596 & https://github.com/openshift/origin/pull/29619

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 01 '25 01:04 openshift-ci-robot

/test all

isabella-janssen avatar Apr 01 '25 01:04 isabella-janssen

@isabella-janssen: This pull request references MCO-1518 which is a valid jira issue.

In response to this:

Included work:

  • Copies over the v1alpha1 MCN api into the v1 folder.
    • Note that the tombstoned fields Spec.PinnedImageSets (being tombstoned as part of #2256) and Status.PinnedImageSets.LastFailedGenerationErrors (previously tombstoned in #2201) are not referenced in the new v1 API.
  • Removes comments suggesting future changes and updates compatibility level.

References:

  • (WIP) Updated enhancement: https://github.com/openshift/enhancements/pull/1765
  • MCN origin tests: https://github.com/openshift/origin/pull/29596 & https://github.com/openshift/origin/pull/29619

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 01 '25 14:04 openshift-ci-robot

@isabella-janssen: This pull request references MCO-1518 which is a valid jira issue.

In response to this:

Included work:

  • Copies over the v1alpha1 MCN api into the v1 folder.
    • Note that the tombstoned fields Spec.PinnedImageSets (being tombstoned as part of #2256) and Status.PinnedImageSets.LastFailedGenerationErrors (previously tombstoned in #2201) are not referenced in the new v1 API.
  • Removes comments suggesting future changes and updates compatibility level.

References:

  • (WIP) Updated enhancement: https://github.com/openshift/enhancements/pull/1765
  • (WIP) MCN origin tests: https://github.com/openshift/origin/pull/29596 & https://github.com/openshift/origin/pull/29619

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 01 '25 14:04 openshift-ci-robot

@isabella-janssen: This pull request references MCO-1518 which is a valid jira issue.

In response to this:

Included work:

  • Copies over the v1alpha1 MCN api into the v1 folder.
    • Note that the tombstoned fields Spec.PinnedImageSets (tombstoned in #2256) and Status.PinnedImageSets.LastFailedGenerationErrors (tombstoned in #2201) are not referenced in the new v1 API.
  • Removes comments suggesting future changes and updates compatibility level.

References:

  • (WIP) Updated enhancement: https://github.com/openshift/enhancements/pull/1765
  • MCN origin tests: https://github.com/openshift/origin/pull/29596

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 09 '25 19:04 openshift-ci-robot

@isabella-janssen: This pull request references MCO-1518 which is a valid jira issue.

In response to this:

Included work:

  • Copies over the v1alpha1 MCN api into the v1 folder.
    • Note that the tombstoned fields Spec.PinnedImageSets (tombstoned in #2256) and Status.PinnedImageSets.LastFailedGenerationErrors (tombstoned in #2201) are not referenced in this new v1 API.
  • Removes comments suggesting future changes and updates compatibility level.

References:

  • (WIP) Updated enhancement: https://github.com/openshift/enhancements/pull/1765
  • MCN origin tests: https://github.com/openshift/origin/pull/29596

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 11 '25 17:04 openshift-ci-robot

/test all

isabella-janssen avatar Apr 22 '25 14:04 isabella-janssen

@isabella-janssen: This pull request references MCO-1518 which is a valid jira issue.

In response to this:

Included work:

  • Copies over the v1alpha1 MCN api into the v1 folder.
    • Note that the tombstoned fields Spec.PinnedImageSets (tombstoned in #2256) and Status.PinnedImageSets.LastFailedGenerationErrors (tombstoned in #2201) are not referenced in this new v1 API.
  • Removes comments suggesting future changes and updates compatibility level.
  • Validation rule tweaks.

References:

  • (WIP) Updated enhancement: https://github.com/openshift/enhancements/pull/1765
  • MCN origin tests: https://github.com/openshift/origin/pull/29596

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 23 '25 14:04 openshift-ci-robot

/lgtm /hold

This needs to be simul-merged with other PRs

JoelSpeed avatar Apr 23 '25 16:04 JoelSpeed

/lgtm

JoelSpeed avatar Apr 23 '25 16:04 JoelSpeed

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, isabella-janssen, JoelSpeed, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 23 '25 19:04 openshift-ci[bot]

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade 3d76f1835b2cec60bd95faecb1a9bf658850f6e3 link true /test e2e-upgrade
ci/prow/e2e-aws-serial-techpreview 3d76f1835b2cec60bd95faecb1a9bf658850f6e3 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn-techpreview 3d76f1835b2cec60bd95faecb1a9bf658850f6e3 link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 23 '25 20:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/eefa5040-20a5-11f0-8a0e-f7b76c33d93a-0

openshift-ci[bot] avatar Apr 24 '25 00:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3d383de0-20b9-11f0-8245-d9e71b3731c4-0

openshift-ci[bot] avatar Apr 24 '25 03:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7889c9e0-20b9-11f0-8524-344231c7c07b-0

openshift-ci[bot] avatar Apr 24 '25 03:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/122c61b0-20c5-11f0-8010-1f1b1d815219-0

openshift-ci[bot] avatar Apr 24 '25 04:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/29812120-20c5-11f0-9d09-034db7188cd7-0

openshift-ci[bot] avatar Apr 24 '25 04:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5ce89d40-20c5-11f0-96a4-32aa1c32ba62-0

openshift-ci[bot] avatar Apr 24 '25 04:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7e0888a0-20c5-11f0-8eb0-ea8cd5f6f40d-0

openshift-ci[bot] avatar Apr 24 '25 04:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/95862cd0-20c5-11f0-925c-09d901a0a8c8-0

openshift-ci[bot] avatar Apr 24 '25 04:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/aef826f0-20c5-11f0-8fe9-e3dedb3be103-0

openshift-ci[bot] avatar Apr 24 '25 04:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/71e86a30-2107-11f0-9ef1-7deaed7556fd-0

openshift-ci[bot] avatar Apr 24 '25 12:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/899e0e50-2107-11f0-8813-4efaab4b94bc-0

openshift-ci[bot] avatar Apr 24 '25 12:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/93c4ecd0-211d-11f0-9c67-05f1b0b7cb91-0

openshift-ci[bot] avatar Apr 24 '25 15:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b6e0cf40-211d-11f0-92a1-828bd9bc5b39-0

openshift-ci[bot] avatar Apr 24 '25 15:04 openshift-ci[bot]

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701 trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci[bot] avatar Apr 24 '25 16:04 openshift-ci[bot]