api
api copied to clipboard
openshift
Promote CPMSMachineNamePrefix feature gate to default feature set
Hello @chiragkyal! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@chiragkyal: This pull request references OAPE-148 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
/hold
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {vsphere amd64 ha }
error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {metal amd64 ha ipv4}
error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {metal amd64 ha ipv6}
error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {metal amd64 ha dual}
error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {aws amd64 ha }
error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {azure amd64 ha }
It's not able to fetch the jobs, even though they exist. https://sippy.dptools.openshift.org/sippy-ng/tests/4.19/details?filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22contains%22%2C%22value%22%3A%22FeatureGate%3ACPMSMachineNamePrefix%5D%22%7D%5D%7D
There is an issue with the verify feature promotion at the moment, I'm investigating
Looking at the current feature promotion data, we don't have enough runs to be able to pass this right now. Could you please trigger 10 runs using gangway on each of AWS, Azure, GCP and vSphere.
This feature doesn't work on metal platforms so we will have to except the metal platform requirements here
Looking at the current feature promotion data, we don't have enough runs to be able to pass this right now. Could you please trigger 10 runs using gangway on each of AWS, Azure, GCP and vSphere.
I had triggered 3-5 jobs in all these platforms. Might need to trigger more.
@chiragkyal: This pull request references OAPE-148 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
Promote
CPMSMachineNamePrefixfeature gate to default feature set
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@JoelSpeed I think we have sufficient runs now, verify-feature-promotion is failing due to the metal platform only.
/lgtm
/override ci/prow/verify-feature-promotion
This feature does not support metal platforms, all others have passed
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chiragkyal, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion
In response to this:
/lgtm
/override ci/prow/verify-feature-promotion
This feature does not support metal platforms, all others have passed
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD b7680e188c5efa5780f93cb89dfa73d728ed5f12 and 2 for PR HEAD cf5f806f84bc587dcd1dc60bb653c5c501aa8cd6 in total
/retest-required
Remaining retests: 0 against base HEAD b7680e188c5efa5780f93cb89dfa73d728ed5f12 and 2 for PR HEAD cf5f806f84bc587dcd1dc60bb653c5c501aa8cd6 in total
/retest-required
Remaining retests: 0 against base HEAD b7680e188c5efa5780f93cb89dfa73d728ed5f12 and 2 for PR HEAD cf5f806f84bc587dcd1dc60bb653c5c501aa8cd6 in total
CI outage is causing a lot of issues. Slack thread
{ failed to wait for importing imagestreamtags [cluster-version-operator, cli] on ci-op-3rg0nbvt/stable: failed to import tag(s) [cli,cluster-version-operator] on image stream ci-op-3rg0nbvt/stable because of missing definition in the spec}
/retest-required
Remaining retests: 0 against base HEAD b7680e188c5efa5780f93cb89dfa73d728ed5f12 and 2 for PR HEAD cf5f806f84bc587dcd1dc60bb653c5c501aa8cd6 in total