api
api copied to clipboard
openshift
Gate new authconfig fields with featuregate
I heard a rumor that gating some new fields was causing trouble. I made an example showing how to have a field gated on A or B.
https://github.com/openshift/api/pull/2234
Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deads2k
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [deads2k]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-serial | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test e2e-aws-serial |
| ci/prow/okd-scos-images | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test okd-scos-images |
| ci/prow/build | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test build |
| ci/prow/lint | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test lint |
| ci/prow/e2e-upgrade | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test e2e-upgrade |
| ci/prow/e2e-upgrade-out-of-change | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test e2e-upgrade-out-of-change |
| ci/prow/e2e-aws-ovn-hypershift | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/verify-deps | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test verify-deps |
| ci/prow/minor-e2e-upgrade-minor | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test minor-e2e-upgrade-minor |
| ci/prow/integration | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test integration |
| ci/prow/verify-client-go | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test verify-client-go |
| ci/prow/verify | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test verify |
| ci/prow/unit | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test unit |
| ci/prow/e2e-aws-ovn-techpreview | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test e2e-aws-ovn-techpreview |
| ci/prow/minor-images | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test minor-images |
| ci/prow/e2e-aws-serial-techpreview | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/verify-feature-promotion | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test verify-feature-promotion |
| ci/prow/e2e-aws-ovn | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test e2e-aws-ovn |
| ci/prow/images | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test images |
| ci/prow/verify-crd-schema | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test verify-crd-schema |
| ci/prow/e2e-aws-ovn-hypershift-conformance | 266684fd7a3cf45256f2a49545d97873f3ca1019 | link | true | /test e2e-aws-ovn-hypershift-conformance |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@everettraven: Closed this PR.
In response to this:
#2234 merged with changes behind a gate. Closing this
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.