openshift
CCXDEV-14850: align insights DataGather with config
This PR should align the configuration options in DataGather with the InsightsDataGather
@opokornyy: This pull request references CCXDEV-14850 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.
In response to this:
This PR should align the configuration options in DataGather with the InsightsDataGather
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @opokornyy! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Just leaving a general note that some of the changes I've requested are a deviation from the v1alpha1 API that I think would be inherently breaking (i.e removing fields, etc.). I'm still learning what this means for alpha level APIs that are only in TPNU clusters, but I suspect we would likely want to go back and bring the v1alpha1 APIs into alignment (or drop them?).
@JoelSpeed what is the correct approach to follow here?
Since we aren't going to allow clusters to upgrade between v1alpha1 and v1alpha2, we don't need to make changes in the alpha 1 or care about conversion webhooks, so we can make breaking changes here
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: everettraven, JoelSpeed, opokornyy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@opokornyy: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.20.0-202505140744.p0.g9052dea.assembly.stream.el9. All builds following this will include this PR.
