api
api copied to clipboard
openshift
DNM: OCPNODE-3023: Kueue operator api review
We are bringing Kueue into OCP in 4.19. This PR fullfills requirements for an api review.
@kannon92: This pull request references OCPNODE-3023 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @kannon92! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@kannon92: This pull request references OCPNODE-3023 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
We are bringing Kueue into OCP in 4.19. This PR fullfills requirements for an api review.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello,
We decided to call a sync to discuss some options as we need to make progress on some kind of API.
Meeting Doc: https://docs.google.com/document/d/16kJXo3W8lCWgYOPpS5Jd8MTT2nrX68XAZKwH9QFO7sg/edit?usp=sharing
Generally, we know that the MVP for this is going to be integrations/external frameworks. The configuration options are quite complicated and we were worried that we would never really come to a decision trying to add every API field we want in the first round of this.
For our tech preview, we are going to only allow Integrations as a configuration option. Sensible defaults will be set in the controller level so we can deduce the scope of this API for tech preview. Feature gates that RHOAI needs to have enabled for GA will be toggled in the controller.
We still need to figure out a path forward with OLM on blocking upgrades and until we have a clear idea of that, it was causing a lot of friction to include all those configurations without be able to block upgrades.
I pushed up a commit that at least calls out the basic API we want for TP.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kannon92 Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@kannon92: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/verify | b295d9b91ace8a0015e6671833414a2169b7583b | link | true | /test verify |
| ci/prow/verify-crd-schema | b295d9b91ace8a0015e6671833414a2169b7583b | link | true | /test verify-crd-schema |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.