api
api copied to clipboard
openshift
WIP: rebase-1.32
Hello @kannon92! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kannon92 Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@kannon92: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/verify-crd-schema | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test verify-crd-schema |
| ci/prow/minor-images | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test minor-images |
| ci/prow/verify-deps | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test verify-deps |
| ci/prow/verify-crd-schema | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test verify-crd-schema |
| ci/prow/verify-client-go | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test verify-client-go |
| ci/prow/okd-scos-images | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test okd-scos-images |
| ci/prow/unit | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test unit |
| ci/prow/build | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test build |
| ci/prow/unit | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test unit |
| ci/prow/verify-feature-promotion | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test verify-feature-promotion |
| ci/prow/lint | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test lint |
| ci/prow/verify | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test verify |
| ci/prow/verify-deps | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test verify-deps |
| ci/prow/images | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test images |
| ci/prow/verify | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test verify |
| ci/prow/verify-client-go | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test verify-client-go |
| ci/prow/verify-feature-promotion | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test verify-feature-promotion |
| ci/prow/images | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test images |
| ci/prow/lint | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test lint |
| ci/prow/build | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test build |
| ci/prow/integration | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test integration |
| ci/prow/minor-images | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test minor-images |
| ci/prow/integration | fd2f119877ad2bab355d8fb3beb8e09177214959 | link | true | /test integration |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.