api
api copied to clipboard
openshift
OCPBUGS-48366: Clean backport of transit subnets to 4.13
Although transit switch doesn't exsit in 4.13. We need this flag to allow users to customize the value before upgrading to 4.14.
@pliurh: This pull request references Jira Issue OCPBUGS-48323, which is invalid:
- expected the bug to target the "4.13.z" version, but no target version was set
- release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
- expected dependent Jira Issue OCPBUGS-48358 to target a version in 4.14.0, 4.14.z, but it targets "4.15.z" instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Although transit switch doesn't exsit in 4.13. We need this flag to allow users to customize the value before upgrading to 4.14.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @pliurh! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pliurh Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@pliurh: This pull request references Jira Issue OCPBUGS-48366, which is invalid:
- release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
- expected dependent Jira Issue OCPBUGS-48323 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Although transit switch doesn't exsit in 4.13. We need this flag to allow users to customize the value before upgrading to 4.14.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@pliurh: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@pliurh: This pull request references Jira Issue OCPBUGS-48366, which is invalid:
- release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
- expected dependent Jira Issue OCPBUGS-48323 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@pliurh: This pull request references Jira Issue OCPBUGS-48366, which is invalid:
- expected dependent Jira Issue OCPBUGS-48323 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@zhaozhanqi: This pull request references Jira Issue OCPBUGS-48366, which is valid. The bug has been moved to the POST state.
7 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.13.z) matches configured target version for branch (4.13.z)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
- release note type set to "Release Note Not Required"
- dependent bug Jira Issue OCPBUGS-48323 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
- dependent Jira Issue OCPBUGS-48323 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
- bug has dependents
Requesting review from QA contact: /cc @zhaozhanqi
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@pliurh: This pull request references Jira Issue OCPBUGS-48366, which is valid.
7 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.13.z) matches configured target version for branch (4.13.z)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
- release note type set to "Release Note Not Required"
- dependent bug Jira Issue OCPBUGS-48323 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
- dependent Jira Issue OCPBUGS-48323 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
- bug has dependents
Requesting review from QA contact: /cc @zhaozhanqi
In response to this:
Although transit switch doesn't exsit in 4.13. We need this flag to allow users to customize the value before upgrading to 4.14.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Do we need testsuite like we did in 4.14? https://github.com/openshift/api/commit/82172096a54a48a89e8a3e44ef33590eed5e20cb#diff-83d794e7ea816406ec17f0edc6c94251ffc4e0dfc6e7cf1046ce38fc901fb1e5
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@pliurh: This pull request references Jira Issue OCPBUGS-48366. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.
In response to this:
Although transit switch doesn't exsit in 4.13. We need this flag to allow users to customize the value before upgrading to 4.14.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.