api
api copied to clipboard
openshift
OCPBUGS-48286: feature-gates - enable ServiceAccountTokenNodeBinding
What
Enable ServiceAccountTokenNodeBinding.
Why
It is available in Beta on Kubernetes.
Hello @ibihim! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ibihim: This pull request references Jira Issue OCPBUGS-48286, which is invalid:
- expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
What
Enable
ServiceAccountTokenNodeBinding.Why
It is available in Beta on Kubernetes.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@rtheis: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ibihim: This pull request references Jira Issue OCPBUGS-48286, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.19.0) matches configured target version for branch (4.19.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @wangke19
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD c1a063b1614ac3ccb0fc5ab49ba6158dfe8e3d3e and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
/retest-required
Remaining retests: 0 against base HEAD c1a063b1614ac3ccb0fc5ab49ba6158dfe8e3d3e and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
/retest-required
Remaining retests: 0 against base HEAD c1a063b1614ac3ccb0fc5ab49ba6158dfe8e3d3e and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify
In response to this:
tested upstream
/override ci/prow/verify
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD c1a063b1614ac3ccb0fc5ab49ba6158dfe8e3d3e and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
/retest-required
Remaining retests: 0 against base HEAD c1a063b1614ac3ccb0fc5ab49ba6158dfe8e3d3e and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
/retest-required
Remaining retests: 0 against base HEAD c1a063b1614ac3ccb0fc5ab49ba6158dfe8e3d3e and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
/retest-required
Remaining retests: 0 against base HEAD 52377f09e5c9293d4694c29375b35fb202bae222 and 1 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
/retest-required
Remaining retests: 0 against base HEAD 52377f09e5c9293d4694c29375b35fb202bae222 and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
/retest-required
Remaining retests: 0 against base HEAD 52377f09e5c9293d4694c29375b35fb202bae222 and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
/retest-required
Remaining retests: 0 against base HEAD 52377f09e5c9293d4694c29375b35fb202bae222 and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
/retest-required
Remaining retests: 0 against base HEAD 52377f09e5c9293d4694c29375b35fb202bae222 and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
/retest-required
Remaining retests: 0 against base HEAD 52377f09e5c9293d4694c29375b35fb202bae222 and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify
In response to this:
/override ci/prow/verify
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD 52377f09e5c9293d4694c29375b35fb202bae222 and 2 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
/retest-required
Remaining retests: 0 against base HEAD 366ffb8c60da233a10af049e3869048531b7f6a1 and 1 for PR HEAD b725bdd3a22e7f22a44a0c8f6b0e790f32a1480b in total
@ibihim: This pull request references Jira Issue OCPBUGS-48286, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.19.0) matches configured target version for branch (4.19.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @xingxingxia
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.