api
api copied to clipboard
openshift
OCPNODE-2333: add imagepolicy to payload crds
cooperate PR for https://github.com/openshift/machine-config-operator/pull/4587
@QiWang19: This pull request references OCPNODE-2333 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello @QiWang19! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@QiWang19: This pull request references OCPNODE-2333 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
cooperate PR for https://github.com/openshift/machine-config-operator/pull/4587
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/hold hold for https://github.com/openshift/machine-config-operator/pull/4587
If the CRDs are not presently being added to payload in the MCO repo, then this can merge first, but I notice your PR is also including these in the install dir for MCO, so, it looks like they possibly need to be removed from the install dir so that they aren't introduced into payload twice?
I agree with Joel that the MCO pull should drop its copies of these CRDs. And with that change, I don't see a reason why we can't lift the hold here and land these now. Although I guess you don't want too much space in between this landing and the MCO pull landing, to avoid too many rounds of clusters that have the CRDs in place (via payload-manifests/crds here and the API image) without having a controller in place (via the MCO pull). During that transition period, anyone tetsting the tech-preview types might be surprised to have no controller delivering the spec ask.
The manifests were dropped from MCO PR https://github.com/openshift/machine-config-operator/pull/4587
/lgtm
/hold
Release the hold when you're ready, the serial techpreview is an unrelated flake
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoelSpeed, QiWang19, wking
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 82e082220d910f489d35880174e2eb90e21f5589 and 2 for PR HEAD 8444a7699606d7724015369c11a0bf348a779da4 in total
/retest-required
Remaining retests: 0 against base HEAD 82e082220d910f489d35880174e2eb90e21f5589 and 2 for PR HEAD 8444a7699606d7724015369c11a0bf348a779da4 in total
/retest-required
Remaining retests: 0 against base HEAD 82e082220d910f489d35880174e2eb90e21f5589 and 2 for PR HEAD 8444a7699606d7724015369c11a0bf348a779da4 in total
@QiWang19: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202410091441.p0.ga152302.assembly.stream.el9. All builds following this will include this PR.
