api icon indicating copy to clipboard operation
api copied to clipboard

WRKLDS-1449: add status subresource to networks.operator.openshift.io

Open atiratree opened this issue 1 year ago • 4 comments

-fixes MustHaveStatus error

atiratree avatar Sep 19 '24 13:09 atiratree

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to this:

-fixes MustHaveStatus error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 19 '24 13:09 openshift-ci-robot

Hello @atiratree! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Sep 19 '24 13:09 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 19 '24 13:09 openshift-ci[bot]

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 19 '24 14:09 openshift-ci[bot]

superseded by https://github.com/openshift/api/pull/1983

atiratree avatar Oct 01 '24 15:10 atiratree