api icon indicating copy to clipboard operation
api copied to clipboard

SDN-4919: Revert "OCPBUGS-38414: Revert #1988 "Graduate `UserDefinedNetworks` to GA""

Open tssurya opened this issue 1 year ago • 46 comments

Reverts openshift/api#1996 https://github.com/openshift/origin/pull/28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe.

@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms)

The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again.

tssurya avatar Aug 13 '24 12:08 tssurya

@tssurya: This pull request references SDN-4919 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

Reverts openshift/api#1996 https://github.com/openshift/origin/pull/28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe

@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 13 '24 12:08 openshift-ci-robot

Hello @tssurya! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Aug 13 '24 12:08 openshift-ci[bot]

/payload 4.18 ci blocking /payload 4.18 nightly blocking

tssurya avatar Aug 13 '24 12:08 tssurya

@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cef7fd70-5971-11ef-8e9c-fd73856402bf-0

trigger 10 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cef7fd70-5971-11ef-8e9c-fd73856402bf-1

openshift-ci[bot] avatar Aug 13 '24 12:08 openshift-ci[bot]

/payload cancel

tssurya avatar Aug 13 '24 12:08 tssurya

@tssurya: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

openshift-ci[bot] avatar Aug 13 '24 12:08 openshift-ci[bot]

/payload-abort

tssurya avatar Aug 13 '24 12:08 tssurya

@tssurya: aborted active payload jobs for pull request openshift/api#1997

openshift-ci[bot] avatar Aug 13 '24 12:08 openshift-ci[bot]

@smg247: This PR was included in a payload test run from openshift/origin#28997 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/502783a0-5974-11ef-88ea-51e3322bf150-0

openshift-ci[bot] avatar Aug 13 '24 13:08 openshift-ci[bot]

@smg247: This PR was included in a payload test run from openshift/origin#28997 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c93b2670-5974-11ef-94b4-ebabd8a793eb-0

openshift-ci[bot] avatar Aug 13 '24 13:08 openshift-ci[bot]

/payload 4.18 ci blocking /payload 4.18 nightly blocking

tssurya avatar Aug 14 '24 04:08 tssurya

@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ebfdfce0-59f7-11ef-922d-84ad5312de64-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ebfdfce0-59f7-11ef-922d-84ad5312de64-1

openshift-ci[bot] avatar Aug 14 '24 04:08 openshift-ci[bot]

@tssurya: This pull request references SDN-4919 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

Reverts openshift/api#1996 https://github.com/openshift/origin/pull/28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe.

@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms)

The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 14 '24 04:08 openshift-ci-robot

/lgtm /label qe-approved

anuragthehatter avatar Aug 14 '24 14:08 anuragthehatter

@tssurya: This pull request references SDN-4919 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

Reverts openshift/api#1996 https://github.com/openshift/origin/pull/28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe.

@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms)

The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 14 '24 14:08 openshift-ci-robot

/retest-required

tssurya avatar Aug 14 '24 19:08 tssurya

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d5e52620-5a76-11ef-8cf6-cba82feaebc3-0

openshift-ci[bot] avatar Aug 14 '24 19:08 openshift-ci[bot]

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea0bb010-5a76-11ef-8170-4812ecdc1d87-0

openshift-ci[bot] avatar Aug 14 '24 19:08 openshift-ci[bot]

/retest-required

tssurya avatar Aug 14 '24 21:08 tssurya

/retest-required

tssurya avatar Aug 15 '24 02:08 tssurya

/payload 4.18 ci blocking /payload 4.18 nightly blocking

tssurya avatar Aug 15 '24 02:08 tssurya

@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9cae2d30-5aac-11ef-92b9-f2c993677c34-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9cae2d30-5aac-11ef-92b9-f2c993677c34-1

openshift-ci[bot] avatar Aug 15 '24 02:08 openshift-ci[bot]

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8d2ebc20-5ab7-11ef-8555-1c089b208de9-0

openshift-ci[bot] avatar Aug 15 '24 03:08 openshift-ci[bot]

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1de333d0-5abe-11ef-983f-862ee23e83ff-0

openshift-ci[bot] avatar Aug 15 '24 04:08 openshift-ci[bot]

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3cb7f6b0-5abe-11ef-9387-ff294f89ad91-0

openshift-ci[bot] avatar Aug 15 '24 04:08 openshift-ci[bot]

@ormergi: This PR was included in a payload test run from openshift/origin#28995 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/09943ab0-5b08-11ef-9839-571e36a6895a-0

openshift-ci[bot] avatar Aug 15 '24 13:08 openshift-ci[bot]

@ormergi: This PR was included in a payload test run from openshift/origin#28995 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5fb66670-5b08-11ef-9ac7-70a30b4950ee-0

openshift-ci[bot] avatar Aug 15 '24 13:08 openshift-ci[bot]

/hold we will hold merging this for now because @JoelSpeed showed another workaround that @trozet showed me which is to have lanes run as presubmits with UDN enabled which I didn't know we could do! that will help us get the signal we need.

tssurya avatar Aug 15 '24 16:08 tssurya

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a9f97d80-5bd0-11ef-9106-821b4d285fa7-0

openshift-ci[bot] avatar Aug 16 '24 13:08 openshift-ci[bot]

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259 trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b2636bc0-5bd0-11ef-8f6b-ff174841c8a0-0

openshift-ci[bot] avatar Aug 16 '24 13:08 openshift-ci[bot]