api
api copied to clipboard
openshift
MON-3971: Remove MetricsServer feature gate
cluster-monitoring-operator now by default installs and configures metrics-server and it doesn't need to be behind feature gate anymore.
@slashpai: This pull request references MON-3971 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
In response to this:
cluster-monitoring-operator now by default installs and configures metrics-server and it doesn't need to be behind feature gate anymore.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @slashpai! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@slashpai: trigger 9 job(s) of type blocking for the nightly release of OCP 4.17
- periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade
- periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-upgrade
- periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-rt-upgrade
- periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance
- periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial
- periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade
- periodic-ci-openshift-release-master-nightly-4.17-fips-payload-scan
- periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-bm
- periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-ipv6
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/35832820-554f-11ef-9dcc-9fa7f4650624-0
Thanks!
Maybe we should also clean it in payload-command/render/renderassets/rendered_manifests_test.go?
/hold Let's wait for https://github.com/openshift/api/pull/1780 to set the pace as there are still discussions around "featuregates removing" https://github.com/openshift/api/pull/1780#issuecomment-1993986689
FYI https://github.com/openshift/api/pull/1780 was merged. Reading the latest discussions, I think we should wait until version 4.19 to merge this one.
Looking at the slack thread, I think we are ok to move forward, can you rebase please to address conflicts
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoelSpeed, slashpai
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 8a37acc9b03ee282ba87accec1c717f3e63808e4 and 2 for PR HEAD 4f141fdc4b05d354cf9bc7a611ed569ce4bb587d in total
/retest-required
Remaining retests: 0 against base HEAD 8a37acc9b03ee282ba87accec1c717f3e63808e4 and 2 for PR HEAD 4f141fdc4b05d354cf9bc7a611ed569ce4bb587d in total
@slashpai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-azure | 4f141fdc4b05d354cf9bc7a611ed569ce4bb587d | link | false | /test e2e-azure |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202410241142.p0.g684b2b1.assembly.stream.el9. All builds following this will include this PR.
