api icon indicating copy to clipboard operation
api copied to clipboard

[wip] Remove alibaba

Open jcpowermac opened this issue 1 year ago • 11 comments

jcpowermac avatar Aug 03 '24 15:08 jcpowermac

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Aug 03 '24 15:08 openshift-ci[bot]

Hello @jcpowermac! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Aug 03 '24 15:08 openshift-ci[bot]

/test ?

jcpowermac avatar Aug 03 '24 15:08 jcpowermac

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 03 '24 15:08 openshift-ci[bot]

@jcpowermac: The following commands are available to trigger required jobs:

  • /test build
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-hypershift
  • /test e2e-aws-ovn-techpreview
  • /test e2e-aws-serial
  • /test e2e-aws-serial-techpreview
  • /test e2e-upgrade
  • /test e2e-upgrade-minor
  • /test images
  • /test integration
  • /test unit
  • /test verify
  • /test verify-client-go
  • /test verify-crd-schema
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-azure
  • /test e2e-gcp
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-api-master-build
  • pull-ci-openshift-api-master-e2e-aws-ovn
  • pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
  • pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
  • pull-ci-openshift-api-master-e2e-aws-serial
  • pull-ci-openshift-api-master-e2e-aws-serial-techpreview
  • pull-ci-openshift-api-master-e2e-azure
  • pull-ci-openshift-api-master-e2e-gcp
  • pull-ci-openshift-api-master-e2e-upgrade
  • pull-ci-openshift-api-master-e2e-upgrade-minor
  • pull-ci-openshift-api-master-images
  • pull-ci-openshift-api-master-integration
  • pull-ci-openshift-api-master-unit
  • pull-ci-openshift-api-master-verify
  • pull-ci-openshift-api-master-verify-client-go
  • pull-ci-openshift-api-master-verify-crd-schema
  • pull-ci-openshift-api-master-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 03 '24 15:08 openshift-ci[bot]

/test build /test e2e-aws-ovn

/test e2e-aws-ovn-techpreview

/test e2e-upgrade /test e2e-upgrade-minor /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps

jcpowermac avatar Aug 03 '24 15:08 jcpowermac

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Aug 06 '24 23:08 openshift-merge-robot

@jcpowermac How many components are left that are depending on these APIs that you're aware of?

JoelSpeed avatar Aug 13 '24 15:08 JoelSpeed

@jcpowermac How many components are left that are depending on these APIs that you're aware of?

Probably quite a few. I wanted to get an idea how difficult this would be to remove and start a discussion when we are ready.

Once the vsphere features for 4.18 are in a good place I can circle back to this effort.

jcpowermac avatar Aug 14 '24 13:08 jcpowermac

I had a chat with David and we are happy to remove the API, if the tests can go green as it were, so, preferable we remove all the underlying operator code first and make this the final part

JoelSpeed avatar Aug 14 '24 13:08 JoelSpeed

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Nov 14 '24 01:11 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Jan 04 '25 00:01 openshift-bot

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema 5c439451be3e132be6c24384ca708ef7a5e2d9d8 link true /test verify-crd-schema
ci/prow/integration 5c439451be3e132be6c24384ca708ef7a5e2d9d8 link true /test integration
ci/prow/minor-e2e-upgrade-minor 5c439451be3e132be6c24384ca708ef7a5e2d9d8 link true /test minor-e2e-upgrade-minor
ci/prow/minor-images 5c439451be3e132be6c24384ca708ef7a5e2d9d8 link true /test minor-images
ci/prow/lint 5c439451be3e132be6c24384ca708ef7a5e2d9d8 link true /test lint
ci/prow/verify-feature-promotion 5c439451be3e132be6c24384ca708ef7a5e2d9d8 link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 28 '25 09:01 openshift-ci[bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Feb 28 '25 00:02 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Feb 28 '25 00:02 openshift-ci[bot]