SDN-4900: clean up openshift-sdn references in the API

[danwinship]

• config.openshift.io:
  • Belatedly update a few places to now say that the default plugin is OVNKubernetes, not OpenShiftSDN.
  • Clarify the docs on NetworkMigration to make it clear that it is used for status, not spec.
• operator.openshift.io:
  • Remove references to OpenShift SDN being a supported network type.
  • Mark OpenShiftSDNConfig as deprecated.
  • Belatedly remove the comment claiming that OVNKubernetes is not supported. :grimacing:
  • Clarify that NetworkType migration is no longer supported by current versions of OpenShift, and so setting the associated fields will result in CNO rejecting the configuration.
• network.openshift.io
  • Deprecate all the (OpenShift-SDN-only) types.

Note that all of the network.openshift.io types are now neither read from nor written to by any OCP component. In theory, users might be using them for their own purposes for unknown reasons not related to openshift-sdn, but other than that there's no reason to not just remove those types completely. (Though this PR does not do that.)

[openshift-ci-robot]

@danwinship: This pull request references SDN-4900 which is a valid jira issue.

In response to this:

• config.openshift.io:
• Belatedly update a few places to now say that the default plugin is OVNKubernetes, not OpenShiftSDN.
• Clarify the docs on NetworkMigration to make it clear that it is used for status, not spec.
• operator.openshift.io:
• Remove references to OpenShift SDN being a supported network type.
• Mark OpenShiftSDNConfig as deprecated.
• Belatedly remove the comment claiming that OVNKubernetes is not supported. :grimacing:
• Clarify that NetworkType migration is no longer supported by current versions of OpenShift, and so setting the associated fields will result in CNO rejecting the configuration.
• network.openshift.io
• Deprecate all the (OpenShift-SDN-only) types.

Note that all of the network.openshift.io types are now neither read from nor written to by any OCP component. In theory, users might be using them for their own purposes for unknown reasons not related to openshift-sdn, but other than that there's no reason to not just remove those types completely. (Though this PR does not do that.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci[bot]]

Hello @danwinship! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[danwinship]

@kyrtapz can you re-review?

[kyrtapz]

/lgtm

[danwinship]

/assign knobunc

[knobunc]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, knobunc, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [knobunc]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2c10e58877296b062ee6fc63e7fda1eafe7d1bdc and 2 for PR HEAD 64e5a15e3928c6798d6f328e27cde03413349911 in total

[danwinship]

/retest

[danwinship]

/retest

[openshift-ci[bot]]

@danwinship: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-upgrade-minor	64e5a15e3928c6798d6f328e27cde03413349911	link	true	/test e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@danwinship: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

• config.openshift.io:
• Belatedly update a few places to now say that the default plugin is OVNKubernetes, not OpenShiftSDN.
• Clarify the docs on NetworkMigration to make it clear that it is used for status, not spec.
• operator.openshift.io:
• Remove references to OpenShift SDN being a supported network type.
• Mark OpenShiftSDNConfig as deprecated.
• Belatedly remove the comment claiming that OVNKubernetes is not supported. :grimacing:
• Clarify that NetworkType migration is no longer supported by current versions of OpenShift, and so setting the associated fields will result in CNO rejecting the configuration.
• network.openshift.io
• Deprecate all the (OpenShift-SDN-only) types.

Note that all of the network.openshift.io types are now neither read from nor written to by any OCP component. In theory, users might be using them for their own purposes for unknown reasons not related to openshift-sdn, but other than that there's no reason to not just remove those types completely. (Though this PR does not do that.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[knobunc]

/override ci/prow/minor-e2e-upgrade-minor

[openshift-ci[bot]]

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/minor-e2e-upgrade-minor

In response to this:

/override ci/prow/minor-e2e-upgrade-minor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408211243.p0.g566edf3.assembly.stream.el9. All builds following this will include this PR.