api icon indicating copy to clipboard operation
api copied to clipboard

Add the field "CapacityReservationID" to "AwsMachineProviderConfig"

Open athiruma opened this issue 1 year ago • 3 comments

This PR adds the support of capacity reservation in AwsMachineProviderConfig. A new field, CapacityReservationID, is added. This ID is used while creating the corresponding AWS EC2 instance and the instance is added to the capacity reservation.

athiruma avatar Jul 30 '24 17:07 athiruma

Hello @athiruma! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Jul 30 '24 17:07 openshift-ci[bot]

Hi @athiruma. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jul 30 '24 17:07 openshift-ci[bot]

/cc @mandre @bparees

athiruma avatar Aug 01 '24 04:08 athiruma

/lgtm /ok-to-test

JoelSpeed avatar Aug 09 '24 15:08 JoelSpeed

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: athiruma, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 09 '24 15:08 openshift-ci[bot]

@athiruma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 09 '24 15:08 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408091844.p0.g7f2da4c.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Aug 09 '24 19:08 openshift-bot